Launchpad itself

Uploading a file with the same name triggers a database constraint.

Bug #302449 reported by Henning Eggers
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Данило Шеган

Bug Description

To reproduce do the following.

1. Got to https://translations.launchpad.dev/evolution/trunk/+pots/evolution-2.2/+upload and upload a file names "es.po".
2. Go to https://translations.launchpad.dev/evolution/trunk/+pots/evolution-2.2/es/+upload and try to upload the same file again.
-> OOPs

Traceback (most recent call last):

    * Module zope.publisher.publish, line 141, in publish
      publication.handleException(
    * Module canonical.launchpad.webapp.publication, line 445, in handleException
      raise Retry(exc_info)

Retry: duplicate key value violates unique constraint "translationimportqueueentry__entry_per_importer__unq"<br /> <br />

Related branches

lp:~danilo/launchpad/bug-302449
Brad Crittenden (community): Approve (code)
Diff: 277 lines (+78/-56)
7 files modified
lib/lp/testing/factory.py (+14/-11)
lib/lp/translations/browser/potemplate.py (+4/-1)
lib/lp/translations/doc/sourcepackagerelease-translations.txt (+2/-2)
lib/lp/translations/model/translationimportqueue.py (+32/-34)
lib/lp/translations/tests/test_autoapproval.py (+7/-5)
lib/lp/translations/tests/test_translationimportqueue.py (+18/-0)
lib/lp/translations/utilities/tests/test_translation_importer.py (+1/-3)
Jeroen T. Vermeulen (jtv)
Changed in rosetta:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Ursula Junque (ursinha) wrote :

According to henninge information, this is rather uncommon and should not be causing much trouble.
I'll watch the occurrence of the oopses, and let people know if something unusual happens.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

OOPS-1626RSBR1, OOPS-1626RSBR2

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

The oopses above happened during automatic import from bzr.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Having this happen during imports from bzr can cause unwanted interactions with exports back to the same branch: the changes can be overwritten by the next export.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

More recently: OOPS-2064AQ53

tags: added: oops
Changed in launchpad:
importance: Medium → Critical
Данило Шеган (danilo)
Changed in launchpad:
assignee: nobody → Данило Шеган (danilo)
status: Triaged → In Progress
Revision history for this message
Данило Шеган (danilo) wrote :

This now seems to be more common from the import queue approval form (and the above reproducing instructions don't work).

Revision history for this message
Данило Шеган (danilo) wrote :

I can't find any more recent OOPSes for automatic bzr import (looked through loganberry-bzrsyncd and ackee-bzrsyncd rosettabranches OOPSes), but if they re-appear, they should be filed as a separate bug imho. I'll take care of the import queue approval form oopsing.

Revision history for this message
Данило Шеган (danilo) wrote :

Ok, after looking at new OOPSes, the problem is with multiple templates with the same translation domain. PO file path for POFile:+upload is constructed from the translation domain and language code, so that leads to problems.

In this particular case, it doesn't seem as if bzr import was used, so I need to figure out how did the user create multiple templates with the same domain.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13922 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13922>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Данило Шеган (danilo)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.