generate_uuids.dpatch breaks deactivation

Bug #306275 reported by Phillip Susi
2
Affects Status Importance Assigned to Milestone
dmraid (Ubuntu)
Fix Released
Undecided
Giuseppe Iuculano

Bug Description

Binary package hint: dmraid

04_genereate_uuids.dpatch changes run_task like so:

- if (ret)
- ret = dm_task_run(dmt);
+ if (ret &&
+ DM_DEVICE_CREATE == type)
+ ret = dmraid_uuid(lc, rs, uuid, DM_UUID_LEN) &&
+ dm_task_set_uuid(dmt, uuid) &&
+ dm_task_run(dmt);

This change causes dm_task_run() to only be called for type==DM_DEVICE_CREATE, so when it is called with DM_DEVICE_REMOVE from dm_remove() it creates the task, but never executes it.

This is for the rc14 version in Intrepid, not rc15 in Jaunty.

Related branches

Revision history for this message
Giuseppe Iuculano (giuseppe-iuculano) wrote :
Changed in dmraid:
status: New → Confirmed
Revision history for this message
Kyle Jones (mutiny32) wrote :

Fix has been committed upstream.

Changed in dmraid:
assignee: nobody → giuseppe-iuculano
status: Confirmed → Fix Committed
Nigel Babu (nigelbabu)
tags: removed: patch
Phillip Susi (psusi)
Changed in dmraid (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.