kubuntu-grub-splashimages adds a splashimage config line to GRUB's menu.lst to the wrong place

Bug #32333 reported by Tomáš Hudec
20
Affects Status Importance Assigned to Milestone
grub (Ubuntu)
Invalid
Medium
Unassigned
Dapper
Invalid
Medium
Unassigned
kubuntu-grub-splashimages (Ubuntu)
Invalid
Medium
Unassigned

Bug Description

Postinstall script of kubuntu-grub-splashimages adds a configuration line to GRUB's menu.lst file to the very beginning.
After running update-grub the line is duplicated just before the first auto-kernel option. And moreover, the next run of update-grub writes all existing lines starting with "splashimage=" to the same place and the lines pile up.
Maybe it can be treated as a bug of the script update-grub from the package grub.
Distro: Kubuntu Dapper

description: updated
Changed in kubuntu-grub-splashimages:
status: Unconfirmed → Rejected
Revision history for this message
Raphaël Pinson (raphink) wrote :

I can confirm this bug.
It doesn't prevent grub from working though.
I don't know of a policy regarding where to put this line in menu.lst, and I think if grub-update can detect it and copy it to another place, it could well move it instead and not duplicate it. I'd tend to think this is a bug with update-grub.

Revision history for this message
Tomáš Hudec (tommy-hudec) wrote :

So I'll file this bug as a bug of update-grub script.

Revision history for this message
Raphaël Pinson (raphink) wrote :

I'll move this bug to update-grub rather.

Changed in kubuntu-grub-splashimages:
status: Unconfirmed → Confirmed
Revision history for this message
Tomáš Hudec (tommy-hudec) wrote :

How can I move the bug to another package?
Script update-grub comes from the grub package...

Revision history for this message
Tomáš Hudec (tommy-hudec) wrote :

Ah, done... ok.

Bug description:
update-grup uses "grep" to find lines
^splashimage=
and output (from grep) is written before the first auto-kernel option. If the option splashimage was used in the user section (before auto-generated section), the line gets duplicated because user section is left and auto-generated part receives new config line of slpashimage. On the next run, however, grep outputs two lines starting with splashimage and both are written to auto-generated section. The next run... 3 lines etc.

Changed in grub:
status: Confirmed → Rejected
Changed in grub:
status: Unconfirmed → Confirmed
Revision history for this message
Raphaël Pinson (raphink) wrote : Patch to fix the bug

This patch modifies update-grub to :
 - get only the first instance of ^splashimage= in menu.lst and ignore the following ones
 - remove the existing instances from the original file so the buffer doesn't duplicate them.

Changed in grub:
status: Confirmed → Fix Committed
Revision history for this message
Matt Zimmerman (mdz) wrote :

Raphaël, you set this bug to 'Fix Committed'. To where was the fix committed? If you only meant to bring attention to the patch that you submitted, then this was counter-productive, since bugs marked 'Fix Committed' are considered dealt with, and I happened across this bug by chance. Marking your attachment as a patch is sufficient for that.

Michael, please review this patch.

Changed in grub:
assignee: nobody → mvo
status: Fix Committed → Confirmed
Revision history for this message
Raphaël Pinson (raphink) wrote :

Sorry that was not clear... I already contacted Michael about this patch and he said he could include it but there was no point in it since update-grub had been disabled lately. In these conditions it's not really an existing bug anymore since update-grub won't duplicate the lines anymore. Anyway, I could commit the patch now I guess.

Michael Vogt (mvo)
Changed in grub:
assignee: mvo → nobody
Revision history for this message
wayward4now (wayward4now) wrote :

Still broken in Karmic i686 testing. Apparently this has been a problem since Edgy??

Revision history for this message
Rohan Garg (rohangarg) wrote :

Hi
Im closing this bug since Ubuntu has since moved on to grub2 and also because the kubuntu-grub-splashimages package has been removed [ see bug 457825 ]

Changed in grub (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.