Segfaults bzr if the first action in a directory is 'ci'

Bug #343543 reported by KarlGoetz
2
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Fix Released
Undecided
Jelmer Vernooij

Bug Description

I'm not sure if this error is new or not, so I'm filing the bug.
It seems to be repeatable, so If its not PEBKAC I'm happy to build some debug packages and use them.

Steps to repeat:
copy clean svn checkout to a new copy
cd into the new copy
edit a file
bzr ci

Expected result:
bzr commits (or at least throws a useable error)

Actual result:
first attempt, bzr segfaults. second attempt it backtraces.

Some information:
OS = Debian (/etc/debian-version says sid/squeeze, lsb_release -a says lenny)
Arch = i386

Packages:
ii bzr-svn 0.4.10-2 Bazaar plugin providing Subversion integration
ii libsvn1 1.5.6dfsg-1 Shared libraries used by Subversion
ii python-subversion 1.5.6dfsg-1 Python bindings for Subversion
ii subversion 1.5.6dfsg-1 Advanced version control system

The code repository was created by an svn checkout.
It can be aquired from here: http://svn.gnewsense.svnhopper.net/gnewsense

Steps I took are listed below.

17:27:39 kgoetz@wesnoth:~/gns$ cp -r builder-clean/ builder-launchpad
17:28:04 kgoetz@wesnoth:~/gns$ cd $_
17:28:21 kgoetz@wesnoth:~/gns/builder-launchpad$ vi gen-launchpad-integration
17:30:04 kgoetz@wesnoth:~/gns/builder-launchpad$ bzr ci
Segmentation fault
17:30:20 kgoetz@wesnoth:~/gns/builder-launchpad$ bzr status
modified:
  gen-launchpad-integration
17:30:29 kgoetz@wesnoth:~/gns/builder-launchpad$ bzr info
Lightweight checkout (format: subversion-wc)
Location:
  light checkout root: .
   checkout of branch: http://svn.gnewsense.svnhopper.net/gnewsense/builder/trunk
    shared repository: .
17:30:39 kgoetz@wesnoth:~/gns/builder-launchpad$ bzr ci
bzr: ERROR: svn.core.SubversionException: ("Working copy '/home/kgoetz/gns/builder-launchpad' locked", 155004)

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 846, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 2364, in run
    author=author)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/svn/workingtree.py", line 439, in commit
    wc = self._get_wc(write_lock=True)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/svn/workingtree.py", line 169, in _get_wc
    write_lock, 0, None)
  File "/var/lib/python-support/python2.5/libsvn/wc.py", line 58, in svn_wc_adm_open3
    return apply(_wc.svn_wc_adm_open3, args)
SubversionException: ("Working copy '/home/kgoetz/gns/builder-launchpad' locked", 155004)

bzr 1.5 on python 2.5.4 (linux2)
arguments: ['/usr/bin/bzr', 'ci']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'
plugins:
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.5.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  rebase /usr/lib/python2.5/site-packages/bzrlib/plugins/rebase [0.3.0]
  svn /usr/lib/python2.5/site-packages/bzrlib/plugins/svn [0.4.10]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

17:49:33 kgoetz@wesnoth:~/gns/builder-launchpad$ cd ../builder-snipets/
17:54:06 kgoetz@wesnoth:~/gns/builder-snipets$ bzr ci
Segmentation fault
17:54:24 kgoetz@wesnoth:~/gns/builder-snipets$ bzr ci
bzr: ERROR: svn.core.SubversionException: ("Working copy '/home/kgoetz/gns/builder-snipets' locked", 155004)

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 846, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 2364, in run
    author=author)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/svn/workingtree.py", line 439, in commit
    wc = self._get_wc(write_lock=True)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/svn/workingtree.py", line 169, in _get_wc
    write_lock, 0, None)
  File "/var/lib/python-support/python2.5/libsvn/wc.py", line 58, in svn_wc_adm_open3
    return apply(_wc.svn_wc_adm_open3, args)
SubversionException: ("Working copy '/home/kgoetz/gns/builder-snipets' locked", 155004)

bzr 1.5 on python 2.5.4 (linux2)
arguments: ['/usr/bin/bzr', 'ci']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'
plugins:
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.5.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  rebase /usr/lib/python2.5/site-packages/bzrlib/plugins/rebase [0.3.0]
  svn /usr/lib/python2.5/site-packages/bzrlib/plugins/svn [0.4.10]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

Revision history for this message
KarlGoetz (kgoetz) wrote :

I dont know what svn status "L" means, but I just noticed this (incase its relevant).

19:45:47 kgoetz@wesnoth:~/gns/builder-snipets$ svn status
19:45:49 kgoetz@wesnoth:~/gns/builder-snipets$ echo "" >> gen-launchpad-integration
19:45:57 kgoetz@wesnoth:~/gns/builder-snipets$ bzr ci
Segmentation fault
19:46:05 kgoetz@wesnoth:~/gns/builder-snipets$ svn status
 ML .
M gen-launchpad-integration
  L syslinux
  L tools
  L images
  L images/svg
  L packages
  L packages/deltah
  L packages/deltah/gnewsense-gdm-themes
  L packages/deltah/gnewsense-gdm-themes/deltah
  L packages/deltah/gnewsense-gdm-themes/debian
  L packages/deltah/gnewsense-gdm-themes/po
  L packages/deltah/gnewsense-wallpapers
  L packages/deltah/gnewsense-wallpapers/debian
  L packages/deltah/gnewsense-wallpapers/build
  L packages/deltah/gnewsense-wallpapers/build/share
  L packages/deltah/gnewsense-wallpapers/build/share/gnome-background-properties
  L packages/deltah/gnewsense-wallpapers/po
  L packages/deltah/usplash-theme-gnewsense
  L packages/deltah/usplash-theme-gnewsense/debian
  L packages/deltah/usplash-theme-gnewsense/src
  L packages/deltah/gnewsense-theme
  L packages/deltah/gnewsense-theme/debian
  L packages/deltah/gnewsense-theme/build
  L packages/deltah/gnewsense-theme/build/share
  L packages/deltah/gnewsense-theme/build/share/themes
  L packages/deltah/gnewsense-theme/build/share/themes/gNewSense-Murrine
  L packages/deltah/gnewsense-theme/build/share/applications
  L packages/deltah/gnewsense-theme/build/share/applications/screensavers
  L packages/deltah/gnewsense-theme/gNewSense-Murrine
  L packages/deltah/gnewsense-theme/gNewSense-Murrine/gtk-2.0
  L packages/deltah/gnewsense-theme/po
  L emeta
  L livecd-variants
  L example-content
  L firmware

Revision history for this message
KarlGoetz (kgoetz) wrote :

bother, sorry. This was meant to be in the last paste:

19:46:07 kgoetz@wesnoth:~/gns/builder-snipets$ svn revert .
svn: Working copy '.' locked
svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

please try to reproduce this with 0.5.x. The entire commit code has been rewritten

Changed in bzr-svn:
status: New → Incomplete
Revision history for this message
KarlGoetz (kgoetz) wrote : Re: [Bug 343543] Re: Segfaults bzr if the first action in a directory is 'ci'

On Mon, 16 Mar 2009 12:18:59 -0000
Jelmer Vernooij <email address hidden> wrote:

> please try to reproduce this with 0.5.x. The entire commit code has
> been rewritten
>
> ** Changed in: bzr-svn
> Status: New => Incomplete
>

I might leave this until 0.5.3 migrates out of unstable into testing.

I'll get back to you in a week :)
kk

Revision history for this message
KarlGoetz (kgoetz) wrote :

Current packages in Debian didnt automatically reproduce this issue, so I guess it is fixed up.

Thanks!

Karl.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

thanks for confirming

Changed in bzr-svn:
assignee: nobody → jelmer
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.