Ubuntu
gnome-panel package

Applications Menu Separator Is Shown For Non-Admin Users

Bug #34363 reported by Étienne BERSAC
40
Affects Status Importance Assigned to Milestone
gnome-panel (Ubuntu)
Fix Released
Medium
Ubuntu Desktop Bugs
Ubuntu ubuntu-6.06

Bug Description

Hello,

gnome-menus does not show the Add/Remove launch in the Applications menu for non admin users. But the separator between categories and this launch still remains at the end of the menu.

This separator should be remove for non admin user. Or end menu's separators should not be shown.

Bye.

Revision history for this message
Sebastien Bacher (seb128) wrote :

If you know a way to do this you are welcome, the menu definition is not by user and static. We will probably revert this code and let the menu without the line like it was before

Changed in gnome-menus:
assignee: nobody → desktop-bugs
status: Unconfirmed → Confirmed
Revision history for this message
Étienne BERSAC (bersace) wrote :

Hello,

In fact, this bug may be fixed only by patching gtk. Maybe gtk should remove trailing and doubled separators.

I'm really new to C/gtk+ programming. May be shall i be able to send a patch. Not sure.

Désolé.

Revision history for this message
Étienne BERSAC (bersace) wrote : Re: [Bug 34363] gtk should remove trailing and double separator. (was: g-a-i separator shown even for non admin users)

Hello,

Maybe patching the gtk_menu_popup function should be enough. But this
is out of my skills. Sorry.

Thanks.

Revision history for this message
Sebastien Bacher (seb128) wrote : Re: gtk should remove trailing and double separator. (was: g-a-i separator shown even for non admin users)

That has nothing to do with GTK, the menu comes from gnome-panel and the description of the layout from gnome-menus. You don't want to modify GTK to change the behaviour of a special case of an application

Revision history for this message
Étienne BERSAC (bersace) wrote : Re: [Bug 34363] the applications menu line should be listed only when gnome-app-install is listed too

Seb : You're right. This is not about gtk.

Maybe should we implement a remove_admin_idem and
remove_trailing_separotor in gnome-panel menubar applet ?

Don't know.

Revision history for this message
Étienne BERSAC (bersace) wrote :

Hello,

for now we should just drop the seperator.

Étienne.

Revision history for this message
Corey Burger (corey.burger) wrote : Re: the applications menu line should be listed only when gnome-app-install is listed too

Seperators on the menu should be defined as part of the .menu file in gnome-panels.

Revision history for this message
Gary Coady (garycoady) wrote :

Well I'm surprised that this seems to work first-time. There may be other places that this sort of logic should be applied, too...

Revision history for this message
Gary Coady (garycoady) wrote : Remove unneeded separators

This patch removes unneeded separators, where the list was created from a set of .desktop files.
It's not completely comprehensive because there are possibly other sources too?

Revision history for this message
Sebastien Bacher (seb128) wrote :

Rocking work again Gary!

This upload fixes the issue:

 gnome-panel (2.14.1-0ubuntu13) dapper; urgency=low
 .
   * debian/patches/14_remove_separators.patch:
     - patch by Gary Coady <email address hidden>
     - removed unneeded menu separators, fix the separator being displayed
       to the application menu for non admin users by example (Ubuntu: #34363)

Changed in gnome-panel:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.