test_msgeditor.MsgEditorTest.test__run_editor_EACCES breaks noninteractive test suite
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Low
|
Vincent Ladeuil |
Bug Description
NOTE: this is for 1.13.1 (I can test on 1.14 if it's useful(
./bzrlib/
Example runs:
$ unset EDITOR
$ unset VISUAL
$ ./bzr selftest MsgEditorTest
<snip>
Ran 20 tests in 0.886s
OK
tests passed
=======
$ export EDITOR=vim
$ ./bzr selftest MsgEditorTest
<snip>
Ran 20 tests in 0.886s
OK
tests passed
=======
$ unset EDITOR
$ export VISUAL=vim
$ ./bzr selftest MsgEditorTest
<snip>
<vim invoked>
" =======
" Netrw Directory Listing (netrw v125)
" /tmp/testbzr-
" Sorted by name
" Sort sequence: [\/]$,\
" Quick Help: <F1>:help -:go up dir D:delete R:rename s:sort-by x:exec
" =======
../
eacces.py
fed.sh*
<:q to exit vim>
Ran 20 tests in 23.118s
OK
tests passed
=======
$ export VISUAL=false
$ ./bzr selftest MsgEditorTe
testing: /tmp/prepare-
/tmp/
ERROR: test_msgeditor.
Could not start any editor.
Please specify one with:
- $BZR_EDITOR
- editor=/some/path in /tmp/testbzr-
- $VISUAL
- $EDITOR
Related branches
Changed in bzr: | |
importance: | Undecided → Low |
milestone: | none → 1.14rc1 |
status: | Confirmed → Fix Committed |
Changed in bzr: | |
status: | Fix Committed → Fix Released |
Sounds like test__run_ editor_ EACCES is not correctly isolated.