hwdb +submit failing with KeyError OOPS

Bug #357316 reported by Ursula Junque
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Low
David Murphy
Launchpad itself
Fix Released
Undecided
Unassigned

Bug Description

As seen on OOPS-1192B2211:
  KeyError: 'system'
and on OOPS-1198C1089:
  KeyError: 'distribution'

More: OOPS-1192F2043, OOPS-1192H1100, OOPS-1192H2029, OOPS-1250G1708, OOPS-1250G329

Tags: lp-bugs oops
Ursula Junque (ursinha)
tags: added: oops
Revision history for this message
Abel Deuring (adeuring) wrote :

added checkbox as an affected project, since the form data leading to the OOPS is sent by checkbox.

But LP should not OOPS in such a case.

Changed in malone:
status: New → Triaged
Revision history for this message
Abel Deuring (adeuring) wrote :

Marc, Dave: Is/was this missing "system" value a temporary issue or is there a reason why checkbox omits sometimes this parameter?

Revision history for this message
Abel Deuring (adeuring) wrote :

We see more similar OOPS reports, as in bug 361736 (keyError. distribution, or OOPS-1192C339 : KeyError: 'architecture' . Again: Is this a temporary issue or is there a good reason why these parameters are omitted?

Ursula Junque (ursinha)
description: updated
Revision history for this message
Ursula Junque (ursinha) wrote :

< intellectronica > Ursinha: you've talked to me about that bug and I explained that the OOPS is a feature, and that it's indicating that the data we get from checkbox is bad. A checkbox fix is, as far as i know, ready

Given that, I'm closing the malone task as Invalid. Can anyone comment in the checkbox fix intellectronica mentioned, please? Thanks!

Changed in malone:
status: Triaged → Invalid
David Murphy (schwuk)
Changed in checkbox:
assignee: nobody → Dave Murphy (schwuk)
importance: Undecided → Low
milestone: none → 0.8-featurefreeze
status: New → Triaged
Revision history for this message
Marc Tardif (cr3) wrote :

Abel, there shouldn't be any particular reason why the system id is not being submitted. However, in the event this happens by as a result of plugins being blacklisted in checkbox, would it be possible for Launchpad to return a relevant error message which can be managed by the client instead of oopsing?

Revision history for this message
Abel Deuring (adeuring) wrote :

We can do that. But as Ursula wrote, we meanwhile think of the current behaviour as a feature ;) Let's assume that such an error occurs frequently in a production version of checkbox. In this case, the OOPSes are a good indication that something is really wrong. And you can get access to the OOPS reports, I think, so you have a chance to see what's going wrong.

Also, it were not always the form field "system" that is missing, In duplicates of this bug, bug 361736 , we see that the value of the field "distribution" is missing.

And, BTW, in the case that these errors occured during testing of checkbox: It might make sense to use staging.launchpad.net instead of the main server for this purpose. Otherwise, you're cluttering the main database with some noise ;)

Ursula Junque (ursinha)
description: updated
Revision history for this message
Abel Deuring (adeuring) wrote :

Looking again into the OOPS reports, specifically at the email addresses entered by the users, it seems that these requests came from the production version of checkbox.

For those OOPSes where the parameter "system" is missing, the distribution is specified as Ubuntu 8.04, 8.10 and 9.04.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8995.

Changed in malone:
status: Invalid → Fix Committed
Abel Deuring (adeuring)
Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
Jeff Lane  (bladernr) wrote :

Dave, this was apparently resolved on the LP side ages ago. Is this still something that needs to be open against Checkbox? I've not heard of this before, so chances are it's not an issue in checkbox either, but thought I'd ask before just closing this

Changed in checkbox:
status: Triaged → Incomplete
Ara Pulido (ara)
Changed in checkbox:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.