bzr break-lock lp:foo fails with TypeError: a float is required

Some analysis. The code in question is:

     def prompt(self, prompt, **kwargs):
         """Emit prompt on the CLI."""
         prompt = prompt % kwargs

And the `prompt` there has lp url with user name (e.g. ~ru-bzr) where
tilde character (~) encoded as %7e and this is caused formatting error.

I have a patch.

As you identified this should not affect all urls so I don't think it's a critical problem for 1.14.

Is there a workaround we can use for this cycle? lp: urls are the ones affected, and I'm not sure if downgrading the bzr client is a good idea with the stacking bugs.

2009/4/30 Stuart Bishop <email address hidden>:
> Is there a workaround we can use for this cycle? lp: urls are the ones
> affected, and I'm not sure if downgrading the bzr client is a good idea
> with the stacking bugs.

I think the workaround is to use an explicit ssh url rather than an lp url.

--
Martin <http://launchpad.net/~mbp/>

Rewriting the URL to bzr+ssh: format doesn't work. Neither does rewriting it to an sftp: format URL.

$ bzr break-lock bzr+ssh://bazaar.launchpad.net/~stub/launchpad/pending-db-changes
bzr: ERROR: exceptions.TypeError: a float is required

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 727, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 922, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 559, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 4475, in run
    control.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 135, in break_lock
    return BzrDir.break_lock(self)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 122, in break_lock
    thing_to_unlock.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 2192, in break_lock
    return self._real_branch.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/branch.py", line 115, in break_lock
    self.control_files.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/lockable_files.py", line 140, in break_lock
    self._lock.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/lockdir.py", line 343, in break_lock
    if bzrlib.ui.ui_factory.get_boolean("Break %s" % lock_info):
  File "/usr/lib/python2.6/dist-packages/bzrlib/ui/__init__.py", line 162, in get_boolean
    self.prompt(prompt + "? [y/n]: ")
  File "/usr/lib/python2.6/dist-packages/bzrlib/ui/__init__.py", line 221, in prompt
    prompt = prompt % kwargs
TypeError: a float is required

bzr 1.14 on python 2.6.2 (linux2)
arguments: ['/usr/bin/bzr', 'break-lock', 'bzr+ssh://bazaar.launchpad.net/~stub/launchpad/pending-db-changes']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'
plugins:
  bzrtools /usr/lib/python2.6/dist-packages/bzrlib/plugins/bzrtools [1.14]
  difftools /home/stub/.bazaar/plugins/difftools [0.91]
  launchpad /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad [unknown]
  lpreview /home/stub/.bazaar/plugins/lpreview [unknown]
  netrc_credential_store /usr/lib/python2.6/dist-packages/bzrlib/plugins/netrc_credential_store [unknown]
  pqm /usr/lib/python2.6/dist-packages/bzrlib/plugins/pqm [1.3]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

$ bzr break-lock sftp://bazaar.launchpad.net/~stub/launchpad/pending-db-changes
bzr: ERROR: exceptions.TypeError: a float is required

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 727, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 922, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzr...

I tried to reproduce this bug against a couple of branches of Launchpad using Bazaar 1.15+4312+108 -- I couldn't. Also, looking at the tracebacks, I can't see a reason for this actually being a launchpad-code bug.

I have found that the url does not matter either.

bzr: ERROR: exceptions.TypeError: a float is required

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 727, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 922, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 559, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 4475, in run
    control.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 135, in break_lock
    return BzrDir.break_lock(self)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 122, in break_lock
    thing_to_unlock.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 2192, in break_lock
    return self._real_branch.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/branch.py", line 115, in break_lock
    self.control_files.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/lockable_files.py", line 140, in break_lock
    self._lock.break_lock()
  File "/usr/lib/python2.6/dist-packages/bzrlib/lockdir.py", line 343, in break_lock
    if bzrlib.ui.ui_factory.get_boolean("Break %s" % lock_info):
  File "/usr/lib/python2.6/dist-packages/bzrlib/ui/__init__.py", line 162, in get_boolean
    self.prompt(prompt + "? [y/n]: ")
  File "/usr/lib/python2.6/dist-packages/bzrlib/ui/__init__.py", line 221, in prompt
    prompt = prompt % kwargs
TypeError: a float is required

bzr 1.14.1 on python 2.6.2 (linux2)
arguments: ['/usr/bin/bzr', 'break-lock', 'bzr+ssh://bazaar.launchpad.net/%7Eoem-solutions-releng/bugsy/lexbuild-production/']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_CA.UTF-8'
plugins:
  builddeb /usr/lib/python2.6/dist-packages/bzrlib/plugins/builddeb [unknown]
  bzrtools /usr/lib/python2.6/dist-packages/bzrlib/plugins/bzrtools [1.14]
  fastimport /usr/lib/python2.6/dist-packages/bzrlib/plugins/fastimport [unknown]
  gtk /usr/lib/python2.6/dist-packages/bzrlib/plugins/gtk [0.96.0.dev.1]
  launchpad /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad [unknown]
  netrc_credential_store /usr/lib/python2.6/dist-packages/bzrlib/plugins/netrc_credential_store [unknown]
  pqm /usr/lib/python2.6/dist-packages/bzrlib/plugins/pqm [1.3]
  rebase /usr/lib/python2.6/dist-packages/bzrlib/plugins/rebase [0.4.4]

I also tried with bzr+ssh://bazaar.launchpad.net/~oem-solutions-releng/bugsy/lexbuild-production/ instead of bzr+ssh://bazaar.launchpad.net/%7Eoem-solutions-releng/bugsy/lexbuild-production/ and I got the same error.