rhythmbox can't add a file with '&' to a playlist

Bug #37115 reported by David Mandelberg
42
Affects Status Importance Assigned to Milestone
Rhythmbox
Fix Released
Medium
rhythmbox (Ubuntu)
Fix Released
Medium
Ubuntu Desktop Bugs

Bug Description

When I try to add "Priscilla Herdman/Forever & Always/09. Priscilla Herdman - Somewhere in Time.flac" or another song on the same album or a song by "Simon & Garfunkel" to a playlist in rhythmbox, it does nothing. I think this is because of the ampersand, because other songs can be added.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for your bug. How do you try to add the song to the playlist? What version of Ubuntu do you use? Is the issue from the filename or the tag from the song?

Changed in rhythmbox:
assignee: nobody → desktop-bugs
status: Unconfirmed → Needs Info
Revision history for this message
David Mandelberg (dseomn) wrote :

I dragged the item in the rhythmbox browser over the playlist's name in the 'Source' box. I'm using dapper (rhythmbox 0.9.3.1-0ubuntu3). I'm not sure if it's the filename or the tags because all of my songs are organized the same way in both (i.e. the filenames are all ~/music/ARTIST/ALBUM/00. ARTIST - TRACK.EXT). I think it's the filename because playlists.xml uses the uri, but that's just a guess.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Do you drag it from nautilus or from rhythmbox library to a playlist? Clear descriptions of bugs make the maintainers job easier ...

Revision history for this message
David Mandelberg (dseomn) wrote :

sorry, I meant the rhythmbox library

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you, I've forwarded that upstream: http://bugzilla.gnome.org/show_bug.cgi?id=337047

Changed in rhythmbox:
status: Needs Info → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

fixed with rhythmbox 0.9.4.1 but we will not update it for dapper

Changed in rhythmbox:
status: Confirmed → Fix Committed
Revision history for this message
bjoern (bes-schiessle) wrote : bugfix

If you don't want to update to rhythmbox 0.9.4.1 for Dapper maybe you can fix the bug in the rhythmbox version of Dapper so that all the Dapper users doesn't have to life with this bug?

I have backported the bugfix from rhythmbox 0.9.4.1 to rhythmbox 0.9.3.1-0ubuntu9.

Hope this helps and can be used for Dapper.

Revision history for this message
Sebastien Bacher (seb128) wrote :

have you tried the fix? are you sure it's enough? when I pinged upstream about that they said we might be to backport other similar changes from the CVS with it, that's why I didn't simply use that patch ...

Revision history for this message
bjoern (bes-schiessle) wrote :

yes i have tried it and it works for all tracks i have tested.
It's basically a 1:1 copy of the patch which was accepted by upstream: http://bugzilla.gnome.org/show_bug.cgi?id=333998

Revision history for this message
Sebastien Bacher (seb128) wrote :

discussion from IRC with upstream:

"...
<doctau_> it would also need the code to force a full-db canonicalisation pass, so users don't get duplicates appearing in their library
<seb128> hum
...
<seb128> k, so not something for dapper
<seb128> thank you :)
<doctau_> the code is fairly simple, but db versioning is a problem
<doctau_> that's the change for db version 1.1->1.2, and iirc 0.9.3 was 1.0
<doctau_> so unless you had the 1.0->1.1 change as well, it will break if the user later upgrades :(
<seb128> right
<seb128> that's why I didn't backport it, the CVS change has the db version change
...
<doctau_> seb128: there isn't really a way to do it that is easy, won't break upgrades, and doesn't cause duplicate track listings
<doctau_> so saying "won't fix in dapper" is probably the best option""

Revision history for this message
Sebastien Bacher (seb128) wrote :

fixed with 0.9.5 to edgy

Changed in rhythmbox:
status: Fix Committed → Fix Released
Changed in rhythmbox:
status: Rejected → Fix Released
Changed in rhythmbox:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.