update-manager split changelogs lines

Bug #37194 reported by Étienne BERSAC
20
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Wishlist
Sebastian Heinlein

Bug Description

Hello,

Changelog have a fixed line width and the text is wrapped to this length (maybe 80 charactere). update-manager is not larger enough to show each line in one line. Long lines are splited and that make the result odd.

update-manager shoud have a default width which allow Changes text to fit correctly the window.

Étienne.

Sebastian:
Outstanding issue: reformat the changelog using some regular expression magic.

Revision history for this message
Carthik Sharma (carthik) wrote :

I can recreate this behavior on my PC.

You can resize the window once, and the next time you open the update-manager window, the size will be remembered. I hope this works for you, for now.

I am marking this as "wishlist" since it does not impede normal working.

Changed in update-manager:
status: Unconfirmed → Confirmed
Revision history for this message
Sebastian Heinlein (glatzor) wrote :

we could try to render the changelog better. we did so for the description, but the changelog is a lot trickier. so i would target this for dapper+1

Changed in update-manager:
assignee: nobody → glatzor
Revision history for this message
Étienne BERSAC (bersace) wrote : Re: [Bug 37194] update-manager split changelogs lines

Hello,

> we could try to render the changelog better. we did so for the
> description, but the changelog is a lot trickier. so i would target
> this
> for dapper+1
That's so terrible to win.resize(400,300) ?

Étienne.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

I could ask you the same. Setting a fixed size is bad because you can only match one case. If you care about l18n (strings of different length) and a18n (different font sizes) you won't suggest this.

Revision history for this message
Étienne BERSAC (bersace) wrote : Re: [Bug 37194] Re: update-manager split changelogs lines

Hello,

> Setting a fixed size is bad because you can only match one case. If
> you care about l18n (strings of different length) and a18n
> (different font sizes) you won't suggest this.
I do not suggest do fix the size, just change the default width of
the window so users wont see odd line-breaks. That's all. ChangesLog
are in english, so there is no matter of i18n here.

I just suggest to use set a more consistent default behaviour.
Because with the current behaviour, *all* users which want to read
changes with correct line break have to resize the width of the
window. This is not my configuration, but the default ubuntu one.

Étienne.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

Currently I would like to completely disable the wrapping of the changelog, since a wrapped line is always a format error. We would get a h-scrollbar for too long lines.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

What do you think about this, Étienne?

Revision history for this message
Étienne BERSAC (bersace) wrote :

Hello,

Sorry, for silence. I forgot to answer.

Yes, horizontal scrollbar is an enhancement. That will at least make
people understand that they window can fit the text. And if they
reduce window size, they wont be surprise by seeing end of line
becomine half lines. (wish you understand).

That's the point : currently ChangeLog aren't designed to fit
windows. So te windows have to fit Changelog width. Luckely, this is
not annoying. (e.g. Evolution preference windows width was annoying
for small screen, ChangeLogs do not). A 300 pixels width dialog is
not annoying users.

But the best (for the future) is to use translatable string that fit
windows width. Both for Changes and Description. Those limitations
are upstream : deb, ChangeLog. Not update-manager guilt.

Étienne.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

Could you please clearify how you get the 300 pixels width? I need 666 to avoid wrapping and these is too wide for the default.

Please set the correct window size and run:

sudo gconftool-2 --get /apps/update-manager/window_size

Changed in update-manager:
status: Confirmed → In Progress
description: updated
Revision history for this message
Étienne BERSAC (bersace) wrote :

Hello,

> sudo gconftool-2 --get /apps/update-manager/window_size
The key has no value !?!? :$

I made screenshot. Wish that helps : http://bersace03.free.fr/pub/
captures/update-manager/ .

Étienne.

Revision history for this message
Étienne BERSAC (bersace) wrote :

Hello,

> + Sebastian:
> + Outstanding issue: reformat the changelog using some regular
> expression magic.

I can write some Perl Compatible Regular Expression for this.

Étienne.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

You use a width of 592 pixel in the screenshots. Far too wide for a 640x480 desktop.

Are you sure that you haven't missed the "sudo" in the gconftool-2 call?

It needs more than some regular expression since we need to guess the depth of the bullet listings. Perhaps this is a "won't fix", since the required effort is quite high.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

if you are interessted you could take a look at the rendering code for package descriptions in gnome-app-install: AppInstall/AppInstall.py line 951 and following

Revision history for this message
Étienne BERSAC (bersace) wrote :

Hello,

Sorry, i missed the sudo. The width is 580. And yes, that's too wide.
At least, use h-scrollbars.

I'm not a python programmer. C and PHP (which with I play some PCRE
tricks). That's out of my skills.

Étienne.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

An horizontal scrollbar has been implemented since then. We are closing this report.

Changed in update-manager:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.