code review confusing 'Resubmit' status
Bug #382827 reported by
John A Meinel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Unassigned | ||
Bug Description
I don't see a way to mark a given merge request as "Please resubmit this". I can say in my personal review that I want it resubmitted, but if I mark the overall status as Resubmit, then it just submits the request again (presumably with whatever is the current tip of the branch.)
This is a bit confusing, given that if I want to overall "Approve" a patch, I have to manually set my personal review to Approve, and then the overall status as Approve. So it followed that to request a resubmit, I would mark my personal review as Resubmit, and then the overall status as Resubmit...
Revision history for this message
| John A Meinel (jameinel) wrote | #1 |
| affects: | launchpad → launchpad-code |
| tags: | added: ui |
Revision history for this message
| Jonathan Lange (jml) wrote | #2 |
| Changed in launchpad-code: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: confusing-ui |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Adding a bit more to this.
I don't want to explicitly "Reject" the patch, as it indicates we don't want to land a patch similar to this one, but somehow fixed.
As such, the overall status of:
Work in Progress
Needs Review
Approved
Merged
Rejected
Is insufficient. The "Resubmit" option looks like what I want, but it actually goes ahead and *performs* the resubmission.
Is the intended use case that "Rejected" is only meant to mean "I'm rejecting this version of your merge request, but please fix up the changes and submit another one". If so, how do you say "What you are trying to do does not fit with our project goals, and we would rather not merge something like this."