make dist should fail if C files don't exist or can't be built

Bug #385453 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

On Wed, Jun 10, 2009 at 9:53 AM, Martin Pool<email address hidden> wrote:
[...]
> Hm, so maybe for now (ie for 1.16) we can just make sure that both
> 'make dist' (and the setup.py equivalent) and installing will fail
> unless the C files both exist and can be built?
>

See the thread starting at https://lists.ubuntu.com/archives/bazaar/2009q2/059280.html

Tags: packaging
Revision history for this message
Jonathan Lange (jml) wrote :

Note that the 1.15 & 1.15.1 releases included all C files except for _walkdirs_win32.c.

The underlying problem that caused this will need to be fixed before this bug can be fixed.

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 385453] Re: make dist should fail if C files don't exist or can't be built

Jonathan Lange wrote:
> Note that the 1.15 & 1.15.1 releases included all C files except for
> _walkdirs_win32.c.
>
> The underlying problem that caused this will need to be fixed before
> this bug can be fixed.
>

So we only build win32 on win32, and readdir on POSIX platforms.

*If* we split out generating the .c files from building the extensions,
then we could build all .c files. (See earlier comments about separating
out a 'pyrexc' step from the build process.)

John
=:->

Martin Pool (mbp)
Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
Revision history for this message
Martin Pool (mbp) wrote :

See also bug 383022

Revision history for this message
Jonathan Lange (jml) wrote :

Didn't make 1.16rc1.

Changed in bzr:
milestone: 1.16 → none
Martin Pool (mbp)
Changed in bzr:
status: Triaged → Confirmed
Vincent Ladeuil (vila)
Changed in bzr:
assignee: Vincent Ladeuil (vila) → nobody
assignee: nobody → Vincent Ladeuil (vila)
assignee: Vincent Ladeuil (vila) → nobody
Jelmer Vernooij (jelmer)
tags: added: packaging
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.