Implementation of "Delete Tags"
Bug #386772 reported by
Juho Vepsäläinen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Phatch |
Fix Released
|
Undecided
|
Juho Vepsäläinen | ||
Bug Description
Implementation of https:/
Note that I have not tested it thorougly though "All" option seemed to work just fine and hopefully rest do too.
Revision history for this message
| Juho Vepsäläinen (bebraw) wrote | #1 |
Revision history for this message
| Stani (stani) wrote | #2 |
| Changed in phatch: | |
| assignee: | nobody → stani (stani) |
| importance: | Undecided → Medium |
| status: | New → Fix Committed |
Revision history for this message
| Stani (stani) wrote | #3 |
| Changed in phatch: | |
| assignee: | stani (stani) → Juho Vepsäläinen (bebraw) |
| status: | Fix Committed → Incomplete |
| Changed in phatch: | |
| importance: | Medium → Undecided |
| Changed in phatch: | |
| status: | Incomplete → Fix Committed |
| Changed in phatch: | |
| milestone: | none → 0.2.1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Juho,
Phatch is compatible with py2.4 so do not use:
condition = condition if condition else always_true
With multiple if statements, it is better to use elif.
photo.metadata is just a buffer for changed metadata values, so your patch won't work even not for "All'. It surprises me it did for you.
You'll have to lookup photo.info for possible metatags, as metadata should be empty by default unless some action modified metadata. It is better to use regular expressions, as otherwise for the 'All' method you need to check two conditions.
I rewrote your action and pushed it in the trunk.