QBzr

Close button on qbranch/qmerge runs command again instead of closing dialog window

Bug #387279 reported by Ian Clatworthy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Gary van der Merwe
QBzr 0.12

Bug Description

qbranch --ui-mode correctly leave the dialog up instead of closing it. But the Close button doesn't work - it seems to try to run the branch command a second time (which is bad) and fails.

A workaround on some operating system's is to use the window close button.

Tags: qbranch qmerge
Ian Clatworthy (ian-clatworthy)
Changed in qbzr:
importance: Undecided → Medium
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Ian:

When you got the error, was it from the subprocess (which would have shown the error in the status widget of the branch dialog, bellow the progress bar), or was it an error from the current process (which would have shown the error in a new dialog.)

If the error was from the subprocess, it will have nothing to do with --ui-mode.

If the error was from the current process, then please post the stack trace. That will be helpfull in fixing.

Changed in qbzr:
status: New → Incomplete
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote : Re: [Bug 387279] Re: Close button on qbranch --ui-mode doesn't work

Gary van der Merwe wrote:
> Ian:
>
> When you got the error, was it from the subprocess (which would have
> shown the error in the status widget of the branch dialog, bellow the
> progress bar), or was it an error from the current process (which would
> have shown the error in a new dialog.)
>
>
 The error appears in the status widget. After branching test to test2
correctly, selecting Close adds this ...

bzr: ERROR: Target directory "test2" already exists.

> If the error was from the subprocess, it will have nothing to do with
> --ui-mode.
>
I think the bug is that selecting Close tries to run the subprocess
again. It shouldn't.

Ian C.

Revision history for this message
Gary van der Merwe (garyvdm) wrote : Re: Close button on qbranch --ui-mode doesn't work

I don't see a close button after an error. I still see "Cancel" and "Ok". Ok runs runs again. Cancel closes the dialog.

WFM

summary: - Close button on qbranch --ui-mode doesn't work
+ Close button on qbranch runs command if there was an error.
Revision history for this message
Alexander Belchenko (bialix) wrote : Re: Close button on qbranch runs command if there was an error.

The same bug and with qmerge window: Pressing Close *after* successful merge seems trigger merge again. It should not!

Revision history for this message
Alexander Belchenko (bialix) wrote :

Gary, this is for --ui-mode, e.g. running qmerge --ui-mode (I've asked Ian to add --ui-mode option when qbzr commands invoked from bzr explorer application).

Changed in qbzr:
importance: Medium → High
status: Incomplete → Confirmed
tags: added: qmerge
summary: - Close button on qbranch runs command if there was an error.
+ Close button on qbranch/qmerge runs command again instead of closing
+ dialog window
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Ah - ok - I was able to reproduce this. I'll take a look.

Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
Gary van der Merwe (garyvdm)
Changed in qbzr:
status: Confirmed → Fix Committed
Alexander Belchenko (bialix)
Changed in qbzr:
milestone: none → 0.12
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.