Checkwatches shouldn't record an OOPS if there isn't an ExternalBugTracker for a given BugTrackerType
Bug #390543 reported by
Graham Binns
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
William Grant | ||
Bug Description
What happens:
When checkwatches encounters a BugTracker with a BugTrackerType for which there isn't an ExternalBugTracker (e.g. GOOGLE_CODE, SAVANE or EMAIL_ADDRESS), it records an OOPS, OOPS-1268CCW2361. These OOPSes are pretty much useless, because all they're doing is nagging us to implement a feature and thus they lower the signal to noise ratio of the checkwatches OOPS report.
What should happen:
checkwatches shouldn't log OOPSes for these circumstances. Situations where we couldn't load an ExternalBugTracker for a BugTrackerType that actually has one are pretty much excluded by tests anyway, since the ExternalBugTracker -> BugTracker mapping is all done in code.
Related branches
lp:~wgrant/launchpad/bug-390543
- Steve Kowalik (community): Approve
-
Diff: 269 lines (+30/-132)3 files modifiedlib/lp/bugs/doc/checkwatches-cli-switches.txt (+0/-2)
lib/lp/bugs/doc/checkwatches.txt (+30/-122)
lib/lp/bugs/scripts/checkwatches/core.py (+0/-8)
| tags: | added: oops |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad: | |
| importance: | Medium → Critical |
Revision history for this message
| William Grant (wgrant) wrote | #2 |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| status: | In Progress → Triaged |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| Changed in launchpad: | |
| milestone: | none → 11.04 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Graham, what will remind us to write this feature? (E.g. how will we explain to a user that a watch cannot sync?)