cannot view private branch if you cannot see the private branch it is stacked on
Bug #393566 reported by
Jonathan Lange
This bug affects 7 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Ian Booth | ||
Bug Description
To see a stacked branch, you must be able to see both the stacked branch and the stacked-on branch. For private branches, this means you must be subscribed to both the stacked branch and the stacked-on branch.
It's very easy to be subscribed only to the stacked branch. This leads to confusion.
I had thought this was fixed by the fix for bug 342467. It turns out though that the fix was specific to the code index page, which is a little disappointing.
Possible solutions
==================
* When granting access to a stacked branch, grant access to the stacked on branch (but still require access to the stacked on branch to create a stacked branch).
Related branches
lp:~wallyworld/launchpad/view-private-stacked-branch-393566
- Abel Deuring (community): Approve (code)
-
Diff: 415 lines (+174/-35)9 files modifiedlib/lp/code/interfaces/branch.py (+3/-0)
lib/lp/code/interfaces/branchcollection.py (+3/-0)
lib/lp/code/model/branch.py (+12/-0)
lib/lp/code/model/branchcollection.py (+15/-15)
lib/lp/code/model/tests/test_branch.py (+23/-0)
lib/lp/code/model/tests/test_branchcollection.py (+20/-7)
lib/lp/registry/interfaces/sharingservice.py (+12/-0)
lib/lp/registry/services/sharingservice.py (+42/-0)
lib/lp/registry/services/tests/test_sharingservice.py (+44/-13)
lp:~wallyworld/launchpad/view-private-stacked-branch2-393566
- Curtis Hovey (community): Approve (code)
-
Diff: 479 lines (+236/-32)10 files modifiedlib/lp/code/interfaces/branch.py (+5/-1)
lib/lp/code/interfaces/branchcollection.py (+3/-0)
lib/lp/code/model/branch.py (+37/-2)
lib/lp/code/model/branchcollection.py (+15/-15)
lib/lp/code/model/tests/test_branch.py (+23/-0)
lib/lp/code/model/tests/test_branchcollection.py (+10/-2)
lib/lp/code/model/tests/test_branchsubscription.py (+82/-0)
lib/lp/registry/interfaces/sharingservice.py (+14/-0)
lib/lp/registry/services/sharingservice.py (+32/-0)
lib/lp/registry/services/tests/test_sharingservice.py (+15/-12)
| tags: | added: canonical-losa-lp |
| tags: | removed: ui |
| summary: |
- Stacking and privacy interact poorly + cannot view private branch if you cannot see the private branch it is + stacked on |
Revision history for this message
| Gary Poster (gary) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| Changed in launchpad: | |
| assignee: | Ian Booth (wallyworld) → nobody |
| description: | updated |
| tags: | added: disclosure privacy-transitions |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Triaged |
| tags: | added: bad-commit-15625 qa-bad |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-bad qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
See (private) bug 812335, and in particular comment #1.