Update simple edit pages to base-layout
Bug #399010 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Curtis Hovey |
Bug Description
+edit pages should not have side portlets, many do not have navigation menus. These templates can be updated to the main_only base-layout macro. The navigation menus are the real problem here. onecolumn layouts and many older layouts can that edit pages can by changed to main_only so long as there is not a substantial change to the UI.
Changed in launchpad-registry: | |
milestone: | 2.2.7 → 2.2.9 |
Changed in launchpad-registry: | |
milestone: | 3.0 → 2.2.8 |
To post a comment you must log in.
Hi Martin.
I have uploaded some screencaps of the announcement and project modification pages I changed to verify the last round of base-layout changes:
https:/ /devpad. canonical. com/~curtis/ edit-pages/
These are not all of the changed pages. I change 4 announcement pages and four project pages, but these examples do a good job representing them all. The bread crumbs will appear when we add them to base-layout. The spacing between the tabs and the h1 will also be fixed when we update base-layout with the new design. The h1 is set by context.title in all examples. ..templates did not set the h1, they are relying on the default behaviour of base-layout
The work at the top of each the page is mechanical. The bottom "Related actions" requires a little thought. I had to fix the icons and move a few links in the browser code to ensure the links rendered correctly in the page. Half of the diff is dedicated to fixing links and making them appear in the page
We may want to reconsider the purpose and display of the NavigationMenu if you want to give each template an option to include a related pages/actions portlet. The groups of edit links for the pages are the same, but I had to remove the current link for each page. A ProjectEditNavi gationMenu could be automatically rendered with a single call to render a portlet in the template. This which would enforce consistency, which is nice. It is also awkward. Consider the series and milestone pages. They all share similar "Related pages" links, but none are the same because each intersects with the project-group, project, series, and milestone objects differently.