Unhelpful error when importing a project with submodules

Bug #400805 reported by Aaron Bentley
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Jelmer Vernooij

Bug Description

If we attempt to import a project that uses submodules, the error emitted is not very helpful:

Ideally, we would make the project as invalid when this happens, explaining that bzr-git does not support submodules at this time.

2009-07-16 09:46:14 INFO 65 bytes transferred |
2009-07-16 09:46:16 INFO git: Counting objects: 3 0
2009-07-16 09:46:32 INFO finding revisions to fetch:generating index 0/8147
2009-07-16 09:46:36 INFO finding revisions to fetch:generating index 0/8147
2009-07-16 09:46:39 INFO finding revisions to fetch 1
2009-07-16 09:47:39 INFO fetching revisions 385/1171
2009-07-16 09:48:39 INFO fetching revisions 679/1171
2009-07-16 09:49:39 INFO fetching revisions 936/1171
2009-07-16 09:49:55 INFO
Traceback (most recent call last):
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/scripts/code-import-worker.py", line 59, in ?
    script.main()
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/scripts/code-import-worker.py", line 54, in main
    import_worker.run()
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/lib/lp/codehosting/codeimport/worker.py", line 395, in run
    self._doImport()
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/lib/lp/codehosting/codeimport/worker.py", line 493, in _doImport
    overwrite=True)
  File "<string>", line 4, in pull_write_locked
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/lib/bzrlib/branch.py", line 855, in pull
    possible_transports=possible_transports, *args, **kwargs)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/optionalbzrplugins/git/branch.py", line 393, in pull
    graph=graph)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/optionalbzrplugins/git/branch.py", line 356, in update_revisions
    interrepo.fetch_objects(determine_wants, self.source.mapping)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/optionalbzrplugins/git/fetch.py", line 437, in fetch_objects
    store, recorded_wants, pb)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/optionalbzrplugins/git/fetch.py", line 335, in import_git_objects
    parent_invs, target_git_object_retriever._idmap, lookup_object)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/optionalbzrplugins/git/fetch.py", line 246, in import_git_tree
    file_id, revision_id, parent_invs, shagitmap, lookup_object)
  File "/srv/importd.launchpad.net/production/launchpad-rev-8208/optionalbzrplugins/git/fetch.py", line 174, in import_git_submodule
    raise NotImplementedError(import_git_submodule)
NotImplementedError: <function import_git_submodule at 0x90040d4>
Import failed:
Traceback (most recent call last):
Failure: twisted.internet.error.ProcessTerminated: A process has ended with a probable error condition: process ended with exit code 1.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I agree this would be nice, but we totally don't have support for interpreting different kinds of failures at the moment.

I also don't think it's a priority right now.

Revision history for this message
Aaron Bentley (abentley) wrote :

We could also just re-raise the exception to explain that the import failed because submodules aren't supported. I think the current situation demands too much knowledge from the people reading the log.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

bzr-git now raises a "SubmodulesRequireSubtrees()" error.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It would be nice if failing code imports could be linked to particular bug reports.

Revision history for this message
Łukasz Jernaś (deejay1) wrote :

Is support for submodules planned? The exception raised says now I should update the tree to a newer bzr version (see http://launchpadlibrarian.net/55669409/deejay1-sparkleshare-master.log )

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Submodule support is bug 402814

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This bug has actually been fixed now: the error message has been improved. For submodule support itself is bug 402814.

Changed in launchpad:
assignee: nobody → Jelmer Vernooij (jelmer)
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.