Remove [I]POTMsgSet.sequence
Bug #401618 reported by
Jeroen T. Vermeulen
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Данило Шеган | ||
Bug Description
We've still got "sequence" in POTMsgSet and IPOTMsgSet. We should remove them soon, because they are no longer in use.
Or shouldn't be, at least. Getting rid of them may expose more problems like bug 388473.
Related branches
lp:~danilo/launchpad/bug-401618
- Aaron Bentley (community): Approve
-
Diff: 300 lines (+39/-55)11 files modifiedlib/lp/translations/browser/configure.zcml (+1/-1)
lib/lp/translations/browser/tests/translationmessage-views.txt (+2/-4)
lib/lp/translations/doc/pofile.txt (+10/-7)
lib/lp/translations/doc/vpotexport.txt (+5/-3)
lib/lp/translations/interfaces/potmsgset.py (+4/-6)
lib/lp/translations/interfaces/translationmessage.py (+4/-0)
lib/lp/translations/model/pofile.py (+1/-1)
lib/lp/translations/model/potmsgset.py (+0/-3)
lib/lp/translations/model/translationmessage.py (+8/-0)
lib/lp/translations/templates/pofile-filter.pt (+4/-4)
lib/lp/translations/tests/test_pofile.py (+0/-26)
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in rosetta: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| assignee: | nobody → Данило Шеган (danilo) |
| milestone: | none → 2.2.8 |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #2 |
Revision history for this message
| Данило Шеган (danilo) wrote | #3 |
| Changed in rosetta: | |
| milestone: | 2.2.8 → 3.0 |
| Changed in rosetta: | |
| milestone: | 3.0 → 3.1.10 |
| Changed in rosetta: | |
| milestone: | 3.1.10 → none |
| assignee: | Данило Шеган (danilo) → nobody |
| tags: | added: tech-debt |
| tags: | added: message-sharing |
| Changed in launchpad: | |
| assignee: | nobody → Данило Шеган (danilo) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We still have it in a surprising number of places; a simple "grep -rIi potmsgset.sequence lib scripts cronscripts" reveals a bunch.
Most of these are simple to fix, but the ZCML path_expression for TranslationMessage also relies on it.