Launchpad itself

Create a milestone link icon looks broken

Bug #401974 reported by Martin Albisetti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs
Launchpad itself 2.2.7

Bug Description

See: https://edge.launchpad.net/hundredpapercuts/karmic/+addrelease

"(+) Create milestone" link has a broken icon (probably from the sprites landings)

Related branches

lp:~edwin-grubbs/launchpad/bug-401974-icon-positioning
Francis J. Lacoste (community): Approve (release-critical)
Brad Crittenden (community): Approve
Diff: None lines
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Martin.

I do not have a branch going of sprite fixes. Do you? Otherwise I think we should ask someone incorporate this one line change to their branch that is RC worthy.

=== modified file 'lib/lp/registry/templates/productrelease-add-from-series.pt'
--- lib/lp/registry/templates/productrelease-add-from-series.pt 2009-07-17 17:59:07 +0000
+++ lib/lp/registry/templates/productrelease-add-from-series.pt 2009-07-20 23:52:33 +0000
@@ -51,7 +51,7 @@
             var select_menu = get_by_id('field.milestone_for_release');
             var create_milestone_link = Y.Node.create(
                 '<a href="+addmilestone" id="create-milestone-link" ' +
- 'class="add js-action">Create milestone</a>');
+ 'class="add js-action sprite">Create milestone</a>');
             select_menu.ancestor().appendChild(create_milestone_link);
             var config = {
                 milestone_form_uri: milestone_form_uri,

tags: added: trivial
Changed in launchpad-registry:
importance: Undecided → High
milestone: none → 2.2.7
Revision history for this message
Martin Albisetti (beuno) wrote :

I don't :/

Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
status: Triaged → In Progress
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Landed in rev8309 in db-devel.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 401974 Fix released

Fixed released in Launchpad sinzui.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.