Collapsible sections don't expand in IE8

Bug #402160 reported by Gavin Panella
This bug report is a duplicate of:  Bug #401748: Cannot create new project in IE8. Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
In Progress
High
Graham Binns

Bug Description

Collapsible sections are broken in IE8 on Windows. For example:

  * https://launchpad.dev/firefox/+filebug

    Search for "a" and you'll be presented with a few possible
    duplicate bugs. The areas will not expand. IE reports an "Error on
    page", "Invalid argument" in dom.js, line 669, char 13.

  * http://launchpad.dev/bugs/11

    The "Add a comment/attachment" area will not expand, yielding the
    same error as above.

The same error messages are reported for both normal and compatibility
mode.

Graham Binns (gmb)
Changed in launchpad:
status: Triaged → In Progress
tags: added: regression
Revision history for this message
Gavin Panella (allenap) wrote :

The following patch to lazr-js shows more information about the error, and also makes things work again. Essentially, the error is caused when val is undefined, and it attempts to do style['height'] = undefined. I don't know why val should be undefined, nor do I know why that should really be a problem. Perhaps just doing val || null would be enough to work around this problem for now.

=== modified file 'lib/yui/3.0.0pr2/build/dom/dom.js'
--- lib/yui/3.0.0pr2/build/dom/dom.js 2008-12-15 13:29:08 +0000
+++ lib/yui/3.0.0pr2/build/dom/dom.js 2009-07-21 11:04:28 +0000
@@ -666,7 +666,12 @@
                     att = CUSTOM_STYLES[att];
                 }
             }
- style[att] = val;
+ try {
+ style[att] = val;
+ }
+ catch (error) {
+ alert('style[' + att + '] = ' + val);
+ }
         }
     },

Revision history for this message
Gavin Panella (allenap) wrote :

Just to confirm, the val || null hack works. But it is a hack. But then IE is also a hack.

Revision history for this message
Gavin Panella (allenap) wrote :

Collapsible sections are broken in IE6 and IE7 too. Again, the val || null hack gets them working again.

affects: launchpad → malone
Changed in malone:
milestone: 2.2.7 → none
milestone: none → 2.2.7
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.