The button "compute taxes" on invoice form is not correctly localized

Bug #407293 reported by Numérigraphe
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
Unassigned
Nominated for 5.0 by Numérigraphe

Bug Description

On the current v5.0 branches,
When I open an invoice and press the button "calculate taxes", the tax summary is refreshed but the taxes names in the new summary (on screen and in the reports) are in the partner's language.
They should be in the user's language on screen, and in the partner's language in reports.
Lionel.

PS: the problam has to be fixed at least in account and account_tax_included.

Related branches

summary: - The button 'compute taxes" on invoice formsnot localized
+ The button "compute taxes" on invoice form is not localized
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote : Re: The button "compute taxes" on invoice form is not localized

Hello Lionel,

Try with any account chart.

If there is a translation available, tax will be translated.

Let us know the updates.

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Lionel,

You are talking about the Bottom Left side One2Many field of Invoice form, ain't you?

The Tax name is translatable , so if the translation is available, It will be translated there too.

For reference , you may go to Financial Management/Configuration/Financial Accounting/Taxes/Taxes.

Thank you.

Changed in openobject-addons:
status: Incomplete → Invalid
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Jay, yes i'm talking about the Bottom Left side One2Many field of Invoice form.
I noticed it is l10ned indeed, but not like it should : the tax name appears in the language of the partner (english by default).
It should appear :
- in the language of the user on the forms
- in the language of the partner on the invoice report
The current code does it the other way round.
Lionel

Changed in openobject-addons:
status: Invalid → New
Revision history for this message
Numérigraphe (numerigraphe) wrote :
Revision history for this message
Numérigraphe (numerigraphe) wrote :
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Actually the problem is that account.invoice.tax is a regular object and the name is not translatable, it can only be in the partner's language.
It may not be high priority but this is annoying for the users. I can see it's a bit tricky.
Lionel.

description: updated
summary: - The button "compute taxes" on invoice form is not localized
+ The button "compute taxes" on invoice form is not correctly localized
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Lionel,

If the tax(account.tax ) is translated well, the name of account.invoice.tax will also be translated.

Make sure, the Partner(customer on invoice) has any language attached. No matter if not yet, this patch will work for any case. If no language to partner is assigned, default user preferenced language will be taken into account.

Currently, account.invoice.tax is made up from account.tax(code-name) .

fixed by revision 2394 <email address hidden>.

Please notify us.
Thanks.

Changed in openobject-addons:
status: New → Fix Released
Revision history for this message
Alexis de Lattre (alexis-via) wrote :

I am also affected by this bug.

I backported the patch to my OpenERP version "5.0.1 + 2 weeks", but without success. I still have the tax name printed in English on the invoice report of a partner who has lang=French.

Lionel, did the bug fixed the issue for you ?

Revision history for this message
Numérigraphe (numerigraphe) wrote :

Alexis de Lattre,
you're right, it still does not work. I didn't realize because here we use the same tax name in English and in French.
Lionel

Changed in openobject-addons:
status: Fix Released → Confirmed
Revision history for this message
Numérigraphe (numerigraphe) wrote :

I investigated a bit further and it turns out our own problem is in account_tax_include: the context is lost in _amount_line2() and lots of other places.
I'll clean it up and post a patch in a moment.
Lionel

Changed in openobject-addons:
status: Confirmed → In Progress
assignee: nobody → Numérigraphe (numerigraphe)
Changed in openobject-addons:
assignee: Numérigraphe (numerigraphe) → nobody
status: In Progress → Confirmed
description: updated
Revision history for this message
Numérigraphe (numerigraphe) wrote : [MERGE] [FIX] account_tax_included: context was lost

Here is a bzr merge directive with a patch to fix this bug in the module
account_tax_included.
I have placed XXX comments in parts that I think are mis-using the context.
Subscribers, can you please let me know if this is right?
Lionel

Revision history for this message
Numérigraphe (numerigraphe) wrote :

I emailed the path to the Launchpad bot, it should come up soon (i hope).
Lionel

Revision history for this message
Numérigraphe (numerigraphe) wrote :

Alexis de Lattre, have you tried the patch I posted, and was it any use to you?
Lionel

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Translation and Context-relevant issues have been fixed in trunk.
Correct me If I missed anything.
Thanks.

Changed in openobject-addons:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.