hr_holidays bad checking on workflow actions

To clarify, you get a list index out of range error when there is no employee linked to the uid.
So it should throw a proper exception explain your login does not have an employee linked or something.

Thank you for reporting.
Fixed by revision 2406 <email address hidden>.

    def holidays_validate(self, cr, uid, ids, *args):
        self.check_holidays(cr,uid,ids)
        vals = {
            'state':'validate',
        }
        ids2 = self.pool.get('hr.employee').search(cr, uid, [('user_id','=', uid)])

        if ids2:
            vals['manager_id'] = ids2[0]
        else:
            raise osv.except_osv(_('Warning !'),_('Either there is no Employee defined, or no User attached with it.'))
        self.write(cr, uid, ids, vals)
        self._create_holiday(cr, uid, ids)
        return True

This code is from the official release, openerp server 5.0.9. the bug is still on it. how to fix it?

To reproduce that bug:
Create a new database, install hr, then remove the "fabien pinckaers" employee. install hr_holidays. you cannot then validate or refuse any holiday request.

When i'm admin, my uid is then 1.
"ids2 = self.pool.get('hr.employee').search(cr, uid, [('user_id','=', uid)])"
that code is looking for an employee with id = 1. the employee with id==1 is "fabien pinckaers". if removed, then the error message raises.

Thanks.

Hello Amine,

I have tried the same steps and checked at my end.
With no employees on a holidays request,when I validate/refuse the request, it raises the warning that "Either there is no Employee defined, or no User attached with it."

Kindly check again.
Thanks.