Documentation in readme about requests id contradicts code

Bug #430826 reported by Lucio Torre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One storage protocol
Triaged
Medium
Lucio Torre

Bug Description

From the readme:
The actual method for generating request IDs doesn't matter as long as
they are even numbers (e.g. 0, 2, 4, ...) and aren't re-used by different
requests on the same connection (but note that some requests may involve
multiple messages). Server responses to a client request will use the
client-supplied request ID, but server-originated messages will have a
server-assigned ID which is odd (e.g. 1, 3, 5, ...). In effect, when the
low bit of the request ID is set, it indicates a server-initiated request.

I believe this is out of date -- the code seems to have server have even ids and client odd ones, the opposite of the README.

request.py also has a comment that still reflects the old usage, in RequestHandler.get_new_request_id().

Changed in ubuntuone-storage-protocol:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Lucio Torre (lucio.torre)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.