links in side portlets are too close
Bug #436247 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Benji York | ||
Bug Description
Links used for navigation (not in context) should be in <ul> or <ul class="horizontal"> to ensure that they have proper spacing and are consistent with the rest of launchpad. The link the the bug listings and bugtask are in divs, which allows them to touch.
Related branches
lp:~benji/launchpad/bug-436247
- Steve Kowalik (community): Approve (code)
-
Diff: 171 lines (+44/-56)4 files modifiedlib/canonical/launchpad/icing/style-3-0.css (+1/-1)
lib/lp/bugs/javascript/subscribers_list.js (+2/-2)
lib/lp/bugs/templates/bug-portlet-actions.pt (+28/-42)
lib/lp/bugs/templates/bug-portlet-subscription.pt (+13/-11)
| Changed in malone: | |
| status: | New → Triaged |
| tags: | added: post-3-ui-cleanup ui |
| Changed in malone: | |
| milestone: | 3.1.10 → none |
| tags: | added: ui-easy |
| tags: |
added: easy removed: ui-easy |
| tags: | removed: post-3-ui-cleanup |
| Changed in launchpad: | |
| assignee: | nobody → Benji York (benji) |
| status: | Triaged → In Progress |
Revision history for this message
| Benji York (benji) wrote | #1 |
| tags: | added: dublin |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-okui removed: qa-needstesting ui |
| tags: |
added: qa-ok ui removed: qa-okui |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
After talking to Curtis, this bug refers to the lists in portlets being implemented with stacked divs instead of ul/li. I'll find as many examples as possible and fix them, starting with the actions portlet and the "Other bug subscribers" portlet.