Inkscape

Preferences dialog has too small default size (regression)

Bug #448728 reported by Petteri Aimonen on 2009-10-11

This bug affects 4 people

Affects		Status	Importance	Assigned to	Milestone
	Inkscape	Fix Released	Low	Patrick Storz	Inkscape 0.92.3 "0.92.3"

Bug Description

Steps to reproduce:
1. Remove inkscape settings folder (~/.inkscape)
2. Start r18905 or newer version of inkscape
3. Open preferences dialog
4. The dialog opens too small and has to be manually resized in order to be usable.

SVN revision 18905 [*] broke the automatic sizing support for the preferences dialog while adding scrolling support to the dialog. The scrolling has to be disabled while calculating the minimum size, but simply doing that will break the scrolling support.

I guess it should set the default size of the dialog window instead of the minimum size. However, the dockable panels -thing makes it complex code-wise.

[*] old SVN repository (sf.net):
<http://inkscape.svn.sourceforge.net/viewvc/inkscape?view=revision&revision=18905>

Same revision in current bazaar repository (launchpad.net):
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/5920>

See original description

Tags:

Revision history for this message

su_v (suv-lp) wrote on 2009-10-11:

related bugs:
Bug #281554 “Controls in Preferences Dialogue Initialise Too Short (min height shld be taller)”
Bug #359411 “preferences dialog not drawing properly when opened for first time” (duplicate)
maybe related:
Bug #357631 “preference window gets smaller over time”

tags:	added: ui
Changed in inkscape:
status:	New → Confirmed

Revision history for this message

xpeed (xpeed-rc) wrote on 2010-07-25:

Tested and confirmed for OpenSuse 11.2 x64 bits
Inkscape 0.47 r22583 Compiled from sources.
Window Manager: fluxbox 1.0

Fluxbox Workaround here -> https://bugs.launchpad.net/inkscape/+bug/281554/comments/4

su_v (suv-lp) on 2013-04-14

Changed in inkscape:
importance:	Undecided → Low

Revision history for this message

Jiabao Wu (jiabaowu) wrote on 2013-04-14:

somepatch.diff Edit (527 bytes, text/plain)

Tried to give a reasonable minimum size to the preference dialog. The attached is the minor change of the codes, and the screenshot of first running Inkscape. Please have review.

Revision history for this message

Jiabao Wu (jiabaowu) wrote on 2013-04-14:

Screenshot from 2013-04-15 02:23:13.png Edit (48.6 KiB, image/png)

And here is the screenshot.

su_v (suv-lp) on 2013-04-14

description:	updated
description:	updated

su_v (suv-lp) on 2013-04-30

Changed in inkscape:
assignee:	nobody → Jiabao Wu (jiabaowu)
status:	Confirmed → In Progress

Revision history for this message

Jon A. Cruz (jon-joncruz) wrote on 2013-05-01:

Although this does give a better initial size, it also prevents the window from being manually changed to be smaller.

On smaller screens this is a definite problem, and one we'll need to address properly.

Revision history for this message

su_v (suv-lp) wrote on 2014-02-25:

@Jiabao Wu - do you plan to continue working on fix for this bug?

Revision history for this message

su_v (suv-lp) wrote on 2014-08-11:

Unassigned - please revert if done in error.

tags:	added: preferences
Changed in inkscape:
assignee:	Jiabao Wu (jiabaowu) → nobody
status:	In Progress → Triaged

Revision history for this message

Patrick Storz (ede123) wrote on 2017-10-27:

Recently looked into this a bit:
Actually we have supposedly cleaver code to set a reasonable size request, see [1].

Unfortunately it does not seem to work (neither in master with gtk3 nor in 0.92.x with gtk2).

In "InkscapePreferences::SetMaxDialogSize()" the function "get_preferred_size()" returns zero (and therefore the size request of the preferences window will be zero).
Replacing some occurrences of "this->show_all_children();" with "this->show()" returns *some* preferred size, but it's still tiny and not anywhere close to reasonably usable...

[1] https://gitlab.com/inkscape/inkscape/blob/b2d879e23ef18ce97e71f95d784da4d672874b4b/src/ui/dialog/inkscape-preferences.cpp#L138-143
[2] https://gitlab.com/inkscape/inkscape/blob/b2d879e23ef18ce97e71f95d784da4d672874b4b/src/ui/dialog/inkscape-preferences.cpp#L2012-2025

Revision history for this message

Patrick Storz (ede123) wrote on 2018-01-12:

Fix committed in
https://gitlab.com/inkscape/inkscape/commit/399b8e98c819d2f686a5176dd23393b183c660ec

The dialog should always have a usable (dynamically calculated) size now while also still being shrinkable down to the minimum size.

I'll also investigate if this can be back-ported to 0.92.x

Changed in inkscape:
status:	Triaged → Fix Committed
assignee:	nobody → Eduard Braun (eduard-braun2)
tags:	added: backport-proposed
Changed in inkscape:
milestone:	none → 0.93

Revision history for this message

Petteri Aimonen (jpa-lp) wrote on 2018-01-13:

#10

Nice, thanks for the fix :)

Revision history for this message

Patrick Storz (ede123) wrote on 2018-01-28:

#11

Backported a modified version to 0.92.x in
https://gitlab.com/inkscape/inkscape/commit/c477208a6d8bdacbaea08fa0a82f39b4aefe1f5c

It's not as nice as the version committed to master but it should work well enough.
Please let me know if this causes any issues so I can have another look before the 0.92.3 release if necessary.