Odoo Addons (MOVED TO GITHUB)

warning module doesn't propagate warnings

Bug #454536 reported by Albert Cervera i Areny - http://www.NaN-tic.com on 2009-10-18

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Undecided	Unassigned

Bug Description

If module 'X' overrides sale_order.onchange_partner_id() function to send a warning to the client and the 'warning' module is installed, depending on the order of execution the warning sent by 'X' may not reach the client because 'warning' doesn't propagate it properly.

Related branches

lp:openobject-addons/5.0

Revision history for this message

Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote on 2009-10-18:

warning.diff Edit (838 bytes, text/x-diff)

This patch fixes the bug.

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2009-10-20:

Hello Albert,

Thank you for reporting.

Would you please go for this patch and notify us?

Thanks.

Changed in openobject-addons:
status:	New → Confirmed

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2009-10-20:

Warning_improved.patch Edit (6.7 KiB, text/plain)

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2009-10-27:

Hello Albert,

Any updates on this?

Thank you.

Revision history for this message

Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote on 2009-10-27:

Sorry. Yes, it seems to work for me, but taking a look at your patch and the original code, I see that text is not marked for translation. Maybe we should add the _("Warning for %s") (please, do not concatenate strings which wouldn't work for translations in some languages). The context is missing in some of the onchange calls the module overrides, but given that should be responsability of the original module I wouldn't change that here.

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2009-10-28:

Yes Albert,

Thank you for pointing this out.

We appreciate this initiative.

Fixed by revision 2454 <email address hidden>.