bzr crash when using the email plugin and smtplib
Bug #463428 reported by
Chris Jones
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
bzr email commit hook |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
I am using the email plugin and I have it configured roughly like this:
[/home/
post_commit_to = blah@blah
post_commit_sender = <email address hidden>
post_commit_
post_commit_mailer = smtplib
smtp_server = smtp.canonical.
smtp_username = lalala
smtp_password = hohoho
and when I start doing operations that trigger email sending, bzr backtraces. crash file attached.
Related branches
Changed in bzr-email: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in bzr-email: | |
status: | In Progress → Fix Committed |
Changed in bzr-email: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is a bug in bzr-emails smtplib implementation. See bug #338261 for how it was fixed in bzrlib itself.
Probably the ideal fix is to just strip out 'smtp_connection' from bzr-email entirely, and get it to use bzrlib. smtp_connection . This isn't the first bug we've squashed in bzrlib's implementation that bzr-email still has. (STARTTLS was the other one that comes to mind)