bzr crash when using the email plugin and smtplib

Bug #463428 reported by Chris Jones
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr email commit hook
Fix Released
Medium
Jelmer Vernooij

Bug Description

I am using the email plugin and I have it configured roughly like this:

[/home/cmsj/some/bzranch]
post_commit_to = blah@blah
post_commit_sender = <email address hidden>
post_commit_push_pull = True
post_commit_mailer = smtplib
smtp_server = smtp.canonical.com:587
smtp_username = lalala
smtp_password = hohoho

and when I start doing operations that trigger email sending, bzr backtraces. crash file attached.

Related branches

Revision history for this message
Chris Jones (cmsj) wrote :
Revision history for this message
John A Meinel (jameinel) wrote :

This is a bug in bzr-emails smtplib implementation. See bug #338261 for how it was fixed in bzrlib itself.

Probably the ideal fix is to just strip out 'smtp_connection' from bzr-email entirely, and get it to use bzrlib.smtp_connection. This isn't the first bug we've squashed in bzrlib's implementation that bzr-email still has. (STARTTLS was the other one that comes to mind)

affects: bzr → bzr-email
Jelmer Vernooij (jelmer)
Changed in bzr-email:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer)
Changed in bzr-email:
status: In Progress → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-email:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.