Odoo Addons (MOVED TO GITHUB)

procurement order with 0 qty should be checked, stock.warehouse.orderpoint for qty_multiple check of 0

Bug #467880 reported by David Janssens on 2009-11-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	High	Unassigned	Odoo Addons (MOVED TO GITHUB) 5.0.8

Bug Description

When clicking "Procurement Orders > New Procurement", is it normal that it is possible to enter a procurement with 0 qty?
I think there should be a constraint qty>0.

Related branches

lp:openobject-addons/5.0

Vinay Rana (OpenERP) (vra-openerp) on 2009-11-02

Changed in openobject-addons:
status:	New → Confirmed

Revision history for this message

Jan Verlaan (jan-verlaan) wrote on 2009-11-02:

A draft procurement order should be possible with qty = 0.
It is used in practice by planners to remind them procuring the product but doesn't know the exact qty now.
It is also used to check if all procurement rules are set correct!

When set to "Confirmed" there should be a check on qty = 0 as suggested.

gpa(OpenERP) (gpa-openerp) on 2009-11-02

Changed in openobject-addons:
assignee:	nobody → gpa(Open ERP) (gpa-openerp)

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2009-11-03:

Thank you for reporting.
It has been improved by revision 2439 <email address hidden>.

Changed in openobject-addons:
status:	Confirmed → Fix Released

Revision history for this message

Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote on 2010-03-09:

I don't understand what was exactly fixed in revision 2439, but doesn't seem the problem announced here was solved in that revision or any other one later.

http://bazaar.launchpad.net/~openerp/openobject-addons/5.0/changes/2439?start_revid=2639

Changed in openobject-addons:
assignee:	gpa(Open ERP) (gpa-openerp) → nobody
status:	Fix Released → Confirmed

Revision history for this message

Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote on 2010-03-09:

mrp.py.diff Edit (555 bytes, text/plain)

The attached patch fixes the problem using an SQL constraint.

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2010-03-10:

Hello Albert,

The fix introduced was followed by the good suggestion from Jan Verlaan.
http://bazaar.launchpad.net/~openerp/openobject-addons/5.0/revision/2438.1.1

Revisions get merged,so we cant really rely on basic revision number.

However, I would like to know your view whether we really need this constraint on stock.warehouse.orderpoint?

Thank you for your time.

Revision history for this message

Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote on 2010-03-10: Re: [Bug 467880] Re: procurement order with 0 qty

Oh! Sorry! It seems I was totally slept.

This should have required another bug report, but anyway, I think we need
another check, in this case in stock.warehouse.orderpoint to ensure multiple
quantity is > 0.

Having this multiple set to zero makes the calculation of minimum stock rules
crash, so yes, I think this check is necessary.

A Dimecres, 10 de març de 2010, Jay (Open ERP) va escriure:
> Hello Albert,
>
> The fix introduced was followed by the good suggestion from Jan Verlaan.
> http://bazaar.launchpad.net/~openerp/openobject-addons/5.0/revision/2438.1.
> 1
>
> Revisions get merged,so we cant really rely on basic revision number.
>
> However, I would like to know your view whether we really need this
> constraint on stock.warehouse.orderpoint?
>
> Thank you for your time.
>