QBzr

Reference to undefined name 'revids_load' in log.py

Bug #485133 reported by Max Bowsher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Alexander Belchenko
QBzr 0.17 "Sapin de Noël"

Bug Description

bzr: ERROR: exceptions.NameError: global name 'revids_load' is not defined

Traceback (most recent call last):
  File "/home/maxb/.bazaar/plugins/qbzr/lib/util.py", line 1020, in decorate
    run_in_loading_queue(f, *args, **kargs)
  File "/home/maxb/.bazaar/plugins/qbzr/lib/util.py", line 1032, in run_in_loading_queue
    f(*args, **kargs)
  File "/home/maxb/.bazaar/plugins/qbzr/lib/uifactory.py", line 32, in decorate
    r = f(*args, **kargs)
  File "/home/maxb/.bazaar/plugins/qbzr/lib/log.py", line 538, in load_delta
    for revid, repo in zip(revids_load, repos)]
NameError: global name 'revids_load' is not defined

bzr 2.0.0 on python 2.6.4 (linux2)
arguments: ['/usr/bin/bzr', 'qlog', 'lp:~ubuntu-branches/ubuntu/feisty/spamassassin/feisty-backports-200911061907', 'lp:~ubuntu-branches/ubuntu/feisty/spamassassin/feisty-backports-200911061909', 'lp:~ubuntu-branches/ubuntu/feisty/spamassassin/feisty-backports']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_GB.UTF-8'
plugins:
...
  qbzr /home/maxb/.bazaar/plugins/qbzr [0.17.0dev]
...

Looking at the file, the name revids_load is completely undefined except in this one reference. Hopefully easy to fix for someone who knows what the code is doing.

Revision history for this message
Alexander Belchenko (bialix) wrote :

I think the right fix should be:

=== modified file 'lib/log.py'
--- lib/log.py 2009-11-17 13:06:45 +0000
+++ lib/log.py 2009-11-19 08:55:06 +0000
@@ -485,7 +485,7 @@
                     repos_revids = [(repos[0], revids)]
                 else:
                     repos_revids = [(repo, [revid])
- for revid, repo in zip(revids_load, repos)]
+ for revid, repo in zip(revids, repos)]

                 for repo, repo_revids in repos_revids:
                     repo_revids = [revid for revid in repo_revids

Max, I can't figure out how to reproduce this problem, so if you can test this fix, it will be nice.

Changed in qbzr:
status: New → In Progress
importance: Undecided → High
milestone: none → 0.17
Revision history for this message
Alexander Belchenko (bialix) wrote :

I think I've fixed this. Please reopen if my fix is not sufficient (trunk revno 1109)

Changed in qbzr:
assignee: nobody → Alexander Belchenko (bialix)
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.