We need to tune CKEditor.

Bug #485446 reported by Tom Hoffman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SchoolTool
Fix Released
Critical
Justas Sadzevičius
1.4
Fix Released
Critical
Gediminas Paulauskas

Bug Description

We need to tune CKEditor. (also, perhaps update our FCKEditor to CKEditor?)

For example we should probably set

CKEDITOR.config.forcePasteAsPlainText to true (see http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.config.html#.forcePasteAsPlainText)

We could also add the "Paste from Word" button, but I doubt users would pick up on it, so just nuking Word's crazy formatting seems safer.

We also want CKEditor to use tags that RML understands by default, for example, <b> instead of <strong>.

Related branches

Changed in schooltool.gradebook:
assignee: nobody → Alan Elkner (aelkner)
importance: Undecided → High
status: New → Confirmed
Changed in schooltool.gradebook:
assignee: Alan Elkner (aelkner) → nobody
description: updated
Changed in schooltool.gradebook:
assignee: nobody → Justas Sadzevičius (justas-pov)
Revision history for this message
Justas Sadzevičius (justas.sadzevicius) wrote :

When it was added, the editor was a 90% solution. Now it definitely needs more tweaking. Some of the currently enabled options make no sense in schooltool. Uploading an image, for one (I saw that somewhere recently).

I'd still like to keep a centralized method that makes a chunk of HTML or text safe for rerportlab. Depending on FCK editor alone is not enough - there are ways around it. Once you store the unsafely escaped data - 90% chance you'll need evolution scripts.

The options you suggested make a lot of sense. I'll go through more of them once I get to this task.

Revision history for this message
Tom Hoffman (tom-hoffman) wrote :

It might be worth just fixing the "pasting from Word" part of this issue, because it comes up very quickly -- I'd say one teachers in ten will do it -- and is a real bitch to filter out.

summary: - Need "Paste from Word" button on FCKEditor
+ We need to tune CKEditor.
description: updated
Changed in schooltool.gradebook:
importance: High → Critical
Changed in schooltool:
assignee: nobody → Justas Sadzevičius (justas-pov)
importance: Undecided → Critical
status: New → Confirmed
milestone: none → 1.4.3
Changed in schooltool.gradebook:
milestone: none → 0.7.2
Revision history for this message
Tom Hoffman (tom-hoffman) wrote :

I'm adding onto this a more critical manifestation of this general bug. Basically, pasting doesn't work at all, at least in the "Add Event" description. That is, you right click, get the little javascript (not OS) paste pop-up, try to use it, and you get a "not found" javascript overlay you can't get rid of.

See attached image.

Revision history for this message
Tom Hoffman (tom-hoffman) wrote :
Revision history for this message
Justas Sadzevičius (justas.sadzevicius) wrote :

Oh, this is very bad. Can reproduce it, also by hitting the paste button in the toolbar...

Changed in schooltool:
status: Confirmed → In Progress
Changed in schooltool.gradebook:
status: Confirmed → In Progress
Changed in schooltool:
status: In Progress → Fix Committed
Changed in schooltool.gradebook:
status: In Progress → Fix Committed
Changed in schooltool:
milestone: 1.4.3 → 1.5.1
Changed in schooltool:
status: Fix Committed → Fix Released
Revision history for this message
Gediminas Paulauskas (menesis) wrote :

I do not see any changes to schooltool.gradebook.

Does HTML editor for comments now work after fixes in schooltool?

How can we test this, i.e. create a comment score system and paste a comment?

Changed in schooltool.gradebook:
status: Fix Committed → Invalid
no longer affects: schooltool.gradebook
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.