dragging a window across tabs leaves you in the old tab

Bug #490627 reported by Michael Rooney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Undecided
Chris Jones
terminator (Ubuntu)
Fix Released
Medium
Chris Jones

Bug Description

Binary package hint: terminator

Thanks for Terminator, it rocks!

However one thing I noticed that is a little disorienting/confusing is that if you drag a window (such as from the title) into another tab and drop it somewhere, you end up back at the old tab. You can now click to the new tab and everything works as expected (the window is there where you dropped it), but it took me a few times to understand what was happening; I expected the window to drop into the new tab and to stay there instead of being taken back to the old tab.

ProblemType: Bug
Architecture: amd64
Date: Mon Nov 30 19:02:41 2009
DistroRelease: Ubuntu 9.10
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
NonfreeKernelModules: nvidia
Package: terminator 0.13+ds1-2
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-15.50-generic
SourcePackage: terminator
Uname: Linux 2.6.31-15-generic x86_64

Related branches

Revision history for this message
Michael Rooney (mrooney) wrote :
Revision history for this message
Chris Jones (cmsj) wrote :

I can't reproduce this in 0.14 - could you try installing that from our PPA?

Changed in terminator (Ubuntu):
status: New → Incomplete
Revision history for this message
Michael Rooney (mrooney) wrote :

Yes indeed, I installed 0.14 and can confirm the issue. It doesn't happen always; in simple cases it seems to do the correct thing. However it seems to be reproducible with the following setup:

1. Create two tabs, with a vertical split in each.
2. From the first tab, drag the left window to the second tab, to the bottom right (creating an hsplit with the right window).

You should now be back in the first tab, even though the window is in the second tab. Not that dragging it back to where it was leaves you in the first window as expected!

Changed in terminator (Ubuntu):
status: Incomplete → New
Revision history for this message
Chris Jones (cmsj) wrote :

Thanks for the reproduction steps, I can now confirm this, even on the newly release 0.92. I'll investigate what's going on.

Changed in terminator (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Michael Rooney (mrooney) wrote : Re: [Bug 490627] Re: dragging a window across tabs leaves you in the old tab

Thanks Chris! After reading my previous comment, I see there was a typo that
makes a sentence have the opposite meaning than what was intended. Where I
wrote "Not that dragging it back to where it was" it should be "NOTE that
dragging it back to where it was", sorry for any confusion that may have
caused.

Revision history for this message
Chris Jones (cmsj) wrote :

For the technically inclined, what's happening here is that as we're removing the terminal from one tab, we drop that tab down to a single terminal, so it removes the Paned widget and adds the Terminal. In-so-doing, the tab notices that it is empty briefly, and removes itself from the Notebook widget, but then adds itself back in, but this causes it to appear at the end of the tab list, not its original place.

I'm not entirely sure how I'm going to stop this behaviour, but at least I know exactly what's causing it!

Changed in terminator (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Chris Jones (cmsj) wrote :

This is fixed in trunk revisoin 995. Thanks for the report!

Changed in terminator (Ubuntu):
status: Triaged → Fix Committed
assignee: nobody → Chris Jones (cmsj)
status: Fix Committed → In Progress
Changed in terminator:
status: New → Fix Committed
assignee: nobody → Chris Jones (cmsj)
Revision history for this message
Michael Rooney (mrooney) wrote :

Awesome, thanks Chris! Is this planned for Lucid or a PPA release, that I
might take advantage of the fix?

Revision history for this message
Chris Jones (cmsj) wrote :

It'll certainly be in 0.93 in our PPA, but I'm hoping I can work something out for Lucid itself. I don't have a firm time for 0.93, but maybe in the next week or so?

Chris Jones (cmsj)
Changed in terminator:
status: Fix Committed → Fix Released
Chris Jones (cmsj)
Changed in terminator (Ubuntu):
status: In Progress → Fix Committed
Chris Jones (cmsj)
Changed in terminator (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.