ndiff crashes when its called with not nmap files

Bug #491623 reported by Johannes
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Debian
Fix Released
Undecided
Unassigned
nmap (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: nmap

steps to reproduce:
noone@neo:~/tmp/c$cat foo && cat bar
1
2
noone@neo:~/tmp/c$ndiff foo bar
Traceback (most recent call last):
  File "/usr/bin/ndiff", line 1036, in <module>
    main()
  File "/usr/bin/ndiff", line 1024, in main
    scan_a.load_from_file(filename_a)
  File "/usr/bin/ndiff", line 56, in load_from_file
    self.load(f)
  File "/usr/bin/ndiff", line 50, in load
    parser.parse(f)
  File "/usr/lib/python2.6/xml/sax/expatreader.py", line 107, in parse
    xmlreader.IncrementalParser.parse(self, source)
  File "/usr/lib/python2.6/xml/sax/xmlreader.py", line 123, in parse
    self.feed(buffer)
  File "/usr/lib/python2.6/xml/sax/expatreader.py", line 211, in feed
    self._err_handler.fatalError(exc)
  File "/usr/lib/python2.6/xml/sax/handler.py", line 38, in fatalError
    raise exception
xml.sax._exceptions.SAXParseException: foo:1:0: syntax error

im missing some errormessages if ndiff is called with files in the wrong format.

ProblemType: Bug
Architecture: i386
Date: Wed Dec 2 23:11:33 2009
DistroRelease: Ubuntu 9.10
Package: nmap 5.00-2
ProcEnviron:
 LANGUAGE=de_DE.UTF-8
 PATH=(custom, user)
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-15.50-generic
SourcePackage: nmap
Uname: Linux 2.6.31-15-generic i686

Revision history for this message
Johannes (thc-gangsta) wrote :
Revision history for this message
Johannes (thc-gangsta) wrote :

i made a mistake with the file ndiff.patch. its just the diff file.
the path is this attachment now.

Revision history for this message
Brian Murray (brian-murray) wrote :

Thank you for providing a patch for this bug report. This particular package is synchronized with Debian so it would be quite helpful if you were to forward the patch to the Debian bug tracker. You can learn more about how to use the Debian bug tracker at https://wiki.ubuntu.com/Debian/Bugs. After you've forwarded the bug report and patch please add a bug watch, following the procedure at http://wiki.ubuntu.com/Bugs/Watches, so we can track the progress of the upstream bug report.

Revision history for this message
Chuck Short (zulcss) wrote :

Again thanks for the patch.

Regards
chuck

Changed in nmap (Ubuntu):
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

this is fixed since a long time :)

Changed in nmap (Ubuntu):
status: Confirmed → Fix Released
Changed in debian:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.