Use out-of-tree CodePress

Bug #492410 reported by Nick Chadwick
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
IVLE
Fix Released
Medium
William Grant

Bug Description

Projects which include third-party packages in their source trees make Baby
Jesus and security people like me cry.

We need to get our CodePress changes upstream and be able to use an
out-of-tree version.

Tags: js refactor

Related branches

Revision history for this message
Matt Giuca (mgiuca) wrote :

This is medium priority. Unlike phpBB, CodePress doesn't present security
vulnerabilities, is much smaller, and doesn't have its own deb package. So it's
'okay' for it to hang around in our source tree a while longer.

The plan to fix is:
1. Update our code to the latest version of CP (apparently refactored a lot).
2. Get our changes pushed upstream (they are not IVLE-specific).
3. Create a deb package for CodePress (this will be stored in the IVLE repository for
the foreseeable future).
4. Have IVLE depend upon this deb package instead.

William Grant (wgrant)
tags: added: js refactor
William Grant (wgrant)
Changed in ivle:
assignee: William Grant (wgrant) → nobody
Revision history for this message
David Coles (dcoles) wrote :

Will be rendered obsolete by migration to CodeMirror (https://bugs.edge.launchpad.net/ivle/+bug/520191).
See lp:~ivle-dev/ivle/codepress branch.

Note: CodeMirror should also be moved out-of-tree before closing.

Changed in ivle:
assignee: nobody → David Coles (dcoles)
milestone: none → 1.0.2
Revision history for this message
David Coles (dcoles) wrote :

That should be lp:~ivle-dev/ivle/codemirror branch.

Changed in ivle:
status: Triaged → In Progress
Revision history for this message
William Grant (wgrant) wrote :

lp:~ivle-dev/ivle/codemirror-srsly is a rebased branch of lp:~ivle-dev/ivle/codemirror, with CodeMirror as an external dependency (I have a libjs-codemirror package in the works).

Changed in ivle:
assignee: David Coles (dcoles) → William Grant (wgrant)
Revision history for this message
William Grant (wgrant) wrote :

Fixed in trunk r1825.

Changed in ivle:
status: In Progress → Fix Committed
William Grant (wgrant)
Changed in ivle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.