External suggestion "Used in" links to disabled template
Bug #504062 reported by
Данило Шеган
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Henning Eggers | ||
Bug Description
We fetch external suggestions even from disabled templates. That's not bad because that way we lose no translations data that can be used. However, links for those translations only work for admins, everybody else gets a "not found error".
This bug is very similar to bug 454570, and another related bug is bug 489942.
OOPS-1461G1076
As an example, see the links on https:/
Related branches
lp:~henninge/launchpad/bug-504062-external-suggestions
- Graham Binns (community): Approve (code)
-
Diff: 324 lines (+117/-17)6 files modifiedlib/lp/translations/browser/potemplate.py (+3/-1)
lib/lp/translations/interfaces/potemplate.py (+13/-0)
lib/lp/translations/model/potemplate.py (+18/-0)
lib/lp/translations/model/potmsgset.py (+11/-8)
lib/lp/translations/scripts/tests/test_cache_suggestive_templates.py (+40/-2)
lib/lp/translations/tests/test_potemplate.py (+32/-6)
| Changed in launchpad: | |
| importance: | High → Critical |
| tags: | added: 404 |
| tags: | added: trivial |
| summary: |
- External suggestion "used in" links to disabled template + External suggestion "Used in" links to disabled template |
| description: | updated |
Revision history for this message
| Henning Eggers (henninge) wrote | #1 |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Henning Eggers (henninge) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Templates for external suggestions are taken from the SuggestivePOTem