Ubuntu
xchat package

Add support for freenode ircd-seven CAP command

Bug #507072 reported by Terence Simpson
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
xchat
Unknown
Unknown
xchat (Debian)
Fix Released
Unknown
xchat (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: xchat

Freenode will soon be moving to its new IRCD (ircd-seven) http://announce.freenode.net/
Part of this change is that the way the client requests the IDENTIFY-MSG capability has changed, see http://dev.freenode.net/ircd-seven/browser/doc/hyperion-migration.txt

This patch adds some basic CAP command parsing ability to maintain use of this feature.

Tags: patch
Revision history for this message
Terence Simpson (tsimpson) wrote :
Revision history for this message
Terence Simpson (tsimpson) wrote :

Updated debdiff

Fabrice Coutadeur (fabricesp)
Changed in xchat (Ubuntu):
assignee: nobody → Fabrice Coutadeur (fabricesp)
status: New → In Progress
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

It seems that the same guy that provide a patch for rssi, also provide a patch for xchat at http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven-identify-msg.patch.txt
It looks a bit different to the one you're submitting: could you have a look and see what is done differently? At a first glance, the way the patch handles the command is cleaner, and less attack prone (by checking the length first, and then each character one by one, as done for other commands).

Thanks,
Fabrice

Changed in xchat (Ubuntu):
assignee: Fabrice Coutadeur (fabricesp) → nobody
status: In Progress → Incomplete
Revision history for this message
Terence Simpson (tsimpson) wrote :

I am unfamiliar with the XChat source, so the patch I produced was just an attempt at preserving the feature, the patch at http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven-identify-msg.patch.txt certainly looks cleaner than mine and does everything my patch does and more.

I would suggest that the patch you posted be used instead of the one I provided, and so I've supplied a debdiff with the new patch.

Changed in xchat (Ubuntu):
status: Incomplete → New
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Uploaded. Thanks for your work!

I updated your patch to add a DEP3 header, like this:
## Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/xchat/+bug/507072
## Bug: http://sourceforge.net/support/tracker.php?aid=2931474
## Origin: http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven-identify-msg.patch.txt
## Description: Add support for ircd-seven CAP command.

Could you also report it to Debian?

Anyway, thanks!

Fabrice

Changed in xchat (Ubuntu):
status: New → Fix Committed
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Also reference the bug you are closing in your changelog :-)

Manually closing the bug report.

Fabrice Coutadeur (fabricesp)
Changed in xchat (Ubuntu):
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Unknown → New
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: New → Fix Released
Revision history for this message
Alexey Sokolov (darthgandalf) wrote :

Current Terence's implementation violates CAP specs.
Now xchat looks only to first capability returned by server.
So, "LS :identify-msg multi-prefix" works, but "LS :multi-prefix identify-msg" doesn't.
This patch makes xchat to look the whole cap list, not only the first one.

Alexey Sokolov (darthgandalf)
Changed in xchat (Ubuntu):
status: Fix Released → Incomplete
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Fix Released → New
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: New → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Fix Committed → Fix Released
Daniel Gimpelevich (daniel-gimpelevich)
Changed in xchat (Ubuntu):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.