Launchpad itself

Bug heat flames should be calculated based on the BugTarget's max heat

Bug #511382 reported by Graham Binns
72
This bug affects 13 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Deryck Hodge
Launchpad itself 10.02

Bug Description

What happens:
Looking at the hottest bug on malone (currently with a heat of ~440) you'll see only grey flames for its hotness. This is because the maximum hotness, which is used to determine how many flames should be shown, is a global constant of 5000. This means that projects whose hottest bugs are far colder than this will end up with heat displayed oddly.

What should happen:
Max heat should be determined on a per-bugtarget basis, so that heat can be a relative value within that bugtarget (so Ubuntu's max bugheat would be ~10,000 right now, whilst Malone's would be ~440). The heat shown on the page should depend upon the context in which you're looking at the bug.

DistroSourcePackages should inherit from their parent distribution.

Related branches

lp:~deryck/launchpad/max-heat-by-target-511382
Björn Tillenius (community): Approve (db)
Eleanor Berger (community): Approve
Stuart Bishop (community): Approve (db)
Diff: 650 lines (+241/-52)
19 files modified
database/schema/comments.sql (+4/-2)
database/schema/patch-2207-34-0.sql (+11/-0)
lib/lp/bugs/browser/bug.py (+0/-22)
lib/lp/bugs/browser/bugtask.py (+33/-8)
lib/lp/bugs/browser/configure.zcml (+0/-5)
lib/lp/bugs/browser/tests/bug-heat-view.txt (+44/-11)
lib/lp/bugs/interfaces/bug.py (+1/-0)
lib/lp/bugs/interfaces/bugtarget.py (+5/-0)
lib/lp/bugs/model/bug.py (+1/-0)
lib/lp/bugs/model/bugtarget.py (+14/-0)
lib/lp/bugs/tests/test_bugheat.py (+82/-0)
lib/lp/registry/configure.zcml (+2/-1)
lib/lp/registry/model/distribution.py (+2/-2)
lib/lp/registry/model/distributionsourcepackage.py (+23/-0)
lib/lp/registry/model/distroseries.py (+5/-0)
lib/lp/registry/model/product.py (+2/-1)
lib/lp/registry/model/productseries.py (+5/-0)
lib/lp/registry/model/project.py (+2/-0)
lib/lp/registry/model/sourcepackage.py (+5/-0)
lp:~intellectronica/launchpad/use-max-heat
Leonard Richardson (community): Approve
Canonical Launchpad Engineering: Pending (code) requested
Diff: 173 lines (+28/-40)
4 files modified
lib/lp/bugs/browser/bug.py (+0/-22)
lib/lp/bugs/browser/bugtask.py (+20/-4)
lib/lp/bugs/browser/configure.zcml (+0/-5)
lib/lp/bugs/browser/tests/bug-heat-view.txt (+8/-9)
Graham Binns (gmb)
tags: added: story-bug-heat
Revision history for this message
Micah Gersten (micahg) wrote :

I think it would be nice if the distro package heat was based on the package if viewed as a package and based on the distro is viewed distro wide.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 511382] Re: Bug heat flames should be calculated based on the BugTarget's max heat

2010/1/27 Micah Gersten <email address hidden>:
> I think it would be nice if the distro package heat was based on the
> package if viewed as a package and based on the distro is viewed distro
> wide.
>

Yes, that makes sense. It's all to do with what context the bug is
viewed in (for example, the same bug might have a task on the upstream
project, too, and when looked at in that context it may be
significantly hotter or colder).

That makes the implementation... interesting. But fun :).

Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Deryck Hodge (deryck)
status: Triaged → In Progress
Revision history for this message
Deryck Hodge (deryck) wrote :

I'm claiming this bug to represent the DB patch part of the work, meaning this bug will be fixed when there is a max_heat attribute on all bug targets. To use the attribute is pretty simple and can be done as part of fixing bug 515239.

Changed in malone:
milestone: none → 10.02
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in db r9047 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/9047>

Changed in malone:
status: In Progress → Fix Committed
Deryck Hodge (deryck)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.