GnuChangelogLogFormatter should print apparent authors not committers
Bug #513322 reported by
Martin von Gagern
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Martin von Gagern |
Bug Description
I was a bit surprised to find out that the GNU ChangeLog log formatter only ever prints committers, not authors.
I guess one of the most important uses of this GNU ChangeLog generation is distributing them with release tarballs. Only mentioning committers fails to give credit to those actually authoring a change, and might also be problematic in terms of copyright issues. So I'd suggest using the first apparent author instead.
Of course it would be even better if there was some command line switch to choose between the alternatives, maybe even name the committer together with the full list of apparent authors. Such a command line switch could be useful to other log formats as well.
Related branches
lp:~gagern/bzr/bug513322-first
- Jelmer Vernooij (community): Needs Fixing (code)
- John A Meinel: Approve
- Martin Pool: Pending requested
-
Diff: 74 lines (+41/-1)3 files modifiedNEWS (+3/-0)
bzrlib/log.py (+1/-1)
bzrlib/tests/test_log.py (+37/-0)
lp:~gagern/bzr/bug513322-authors
- Gary van der Merwe: Approve
- Robert Collins (community): Abstain
- Vincent Ladeuil: Approve
-
Diff: 333 lines (+228/-9)4 files modifiedNEWS (+4/-0)
bzrlib/builtins.py (+9/-2)
bzrlib/log.py (+70/-7)
bzrlib/tests/test_log.py (+145/-0)
Changed in bzr: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: log |
tags: | added: gnu |
Changed in bzr: | |
assignee: | nobody → Martin von Gagern (gagern) |
milestone: | none → 2.2.0 |
status: | Confirmed → Fix Released |
To post a comment you must log in.
I've attached two branches. One does the single one line fix of using the first apparent author for gnu changelog format. I'd like to see this merged into bzr.dev soon.
The other branch, lp:~gagern/bzr/bug513322-authors is a first stab at the suggestion from the last paragraph of the original bug report. It implements a new option, --authors, allowing users to override the author selection method on the command line. The three possible values are "all", "first" and "committer". That one might be much harder to get into bzr.dev, so I'll need some guidance there, and would like to only tackle that when the first branch is merged.