oops when setting the commit message on a merge proposal

Bug #516308 reported by Edwin Grubbs
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tim Penhey

Bug Description

OOPS-1494ED554 occured because the user accessed the merge proposal page on launchpad.net as opposed to code.launchpad.net. Because of this, canonical_url(path_only_if_possible=True) was unable to remove the hostname from the url, since it did not match request.getApplicationURL(). Since the hostname still existed on the url, the normalize_uri() function in client.js did not prepend "/api/beta" to the path.

Related branches

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I guess the fix for this is that the merge proposal page should not appear on launchpad.net

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 516308] Re: oops when setting the commit message on a merge proposal

On Mon, 22 Feb 2010 12:18:35 Michael Hudson wrote:
> I guess the fix for this is that the merge proposal page should not
> appear on launchpad.net
>
yes

Revision history for this message
Martin Pool (mbp) wrote :

I presume that's what's happening here?

Revision history for this message
Tim Penhey (thumper) wrote :

On Tue, 02 Mar 2010 19:05:32 Martin Pool wrote:
> I presume that's what's happening here?
>
> ** Attachment added: "commit-message.png"
> http://launchpadlibrarian.net/39947894/commit-message.png

Not sure actually. That is a pretty weird error.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think that's what's happening there, yeah. Haven't seen an error presented like that, I have to say :-)

Revision history for this message
Martin Pool (mbp) wrote :

yes, that oops is this bug.

Tim Penhey (thumper)
tags: added: code-review oops
Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → In Progress
assignee: nobody → Tim Penhey (thumper)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in launchpad-code:
milestone: none → 10.09
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
Tim Penhey (thumper)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.