Product:+changetranslators should become +settings
Bug #516317 reported by
Данило Шеган
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Данило Шеган |
Bug Description
Product translation page has a link to change permissions, and that link also takes one to set the translation focus series for a product. We should turn the page into "+settings", and make sure the link that takes people there indicates it's more than just permissions.
Related branches
lp:~danilo/launchpad/bug-516317
- Henning Eggers (community): Approve (ui,code)
- Launchpad code reviewers: Pending requested
-
Diff: 654 lines (+88/-112)21 files modifiedlib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+2/-2)
lib/lp/registry/browser/configure.zcml (+0/-7)
lib/lp/registry/browser/distribution.py (+2/-2)
lib/lp/registry/browser/product.py (+1/-9)
lib/lp/registry/configure.zcml (+2/-8)
lib/lp/registry/interfaces/distribution.py (+4/-3)
lib/lp/registry/interfaces/product.py (+2/-2)
lib/lp/translations/browser/configure.zcml (+5/-6)
lib/lp/translations/browser/distribution.py (+10/-9)
lib/lp/translations/browser/product.py (+11/-14)
lib/lp/translations/stories/distribution/xx-distribution-translations.txt (+6/-5)
lib/lp/translations/stories/standalone/xx-potemplate-index.txt (+9/-18)
lib/lp/translations/stories/translationfocus/xx-product-translationfocus.txt (+6/-4)
lib/lp/translations/stories/translationgroups/10-distro-translation-group.txt (+3/-3)
lib/lp/translations/stories/translationgroups/15-product-translation-group.txt (+4/-4)
lib/lp/translations/stories/translationgroups/45-test-distro-restricted-permissions.txt (+2/-1)
lib/lp/translations/stories/translationgroups/46-test-distro-structured-permissions.txt (+1/-1)
lib/lp/translations/stories/translationgroups/xx-change-translation-policy.txt (+10/-9)
lib/lp/translations/templates/distribution-translations.pt (+4/-0)
lib/lp/translations/templates/hastranslationgroup-portlet-translation-groups-and-permission.pt (+0/-5)
lib/lp/translations/templates/project-translations.pt (+4/-0)
Changed in rosetta: | |
assignee: | nobody → Данило Шеган (danilo) |
status: | Triaged → In Progress |
Changed in launchpad: | |
milestone: | none → 11.01 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
In a preimplementation chat for bug 127171, Jeroen and I talked about renaming +changetranslators to +translations- policy .
We already have the „+translations- setting” in ISeries for setting translations import and export and the ideas was to name it „translations- policy” to avoid a confusion between +settings and +translations- settings
For solving bug 127171, I already did the renaming and also updated all tests.
It is ok to do the renaming togheter with but 127171, or we should fix this problem in a different branch ?