register-branch --author without email address

Bug #52033 reported by Jelmer Vernooij
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Björn Tillenius

Bug Description

register-branch with an --author argument that doesn't contain an '@'
causes a confusing error:

bzr: ERROR: xmlrpclib.Fault: <Fault -1: 'Unexpected Zope exception: AssertionError: argument must be tuple or Fault instance'>

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 694, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 656, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 281, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/launchpad/__init__.py", line 111, in run
    branch_object_url = rego.submit(service)
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/launchpad/lp_registration.py", line 140, in submit
    return service.send_request(self._methodname, self._request_params())
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/launchpad/lp_registration.py", line 107, in send_request
    result = method(*method_params)
  File "/usr/lib/python2.4/xmlrpclib.py", line 1096, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.4/xmlrpclib.py", line 1383, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.4/xmlrpclib.py", line 1147, in request
    return self._parse_response(h.getfile(), sock)
  File "/usr/lib/python2.4/xmlrpclib.py", line 1286, in _parse_response
    return u.close()
  File "/usr/lib/python2.4/xmlrpclib.py", line 744, in close
    raise Fault(**self._stack[0])
Fault: <Fault -1: 'Unexpected Zope exception: AssertionError: argument must be tuple or Fault instance'>

bzr 0.9.0dev0 on python 2.4.4.candidate.0 (linux2)

It should say something more user-friendly instead.

Revision history for this message
Andrew Bennetts (spiv) wrote :

This really looks to be a bug on the server side (i.e. Launchpad), rather than bzr. Either Launchpad should accept authors without @, or it should give a useful error message rather than tripping over an assertion. I'm reassigning this to launchpad-bazaar.

Revision history for this message
Andrew Bennetts (spiv) wrote :

I suppose there may be a seperate bug here in "bzr register-branch", which is that it doesn't report XML-RPC errors nicely.

Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 52033] Re: register-branch --author without email address

On Thu, Jul 06, 2006 at 04:40:48AM -0000, Andrew Bennetts wrote:
> This really looks to be a bug on the server side (i.e. Launchpad),
> rather than bzr. Either Launchpad should accept authors without @, or
> it should give a useful error message rather than tripping over an
> assertion. I'm reassigning this to launchpad-bazaar.

I think there's a bug both on the server side in Launchad and in the
bzr plugin. It's definitely a bug in Launchpad, you shouldn't see such
a traceback, you should get a Fault instance back. I have a branch
which allows for testing XMLRPC better so that we can ensure this isn't
broken, and we also need to pull in a fix from Zope3 upstream.

    assignee bjornt

After that's fixed, the bzr plugin might have to be changed to catch all
the Fault instances to provide better error messages.

Changed in launchpad-bazaar:
assignee: nobody → bjornt
Changed in launchpad-bazaar:
importance: Untriaged → Medium
status: Unconfirmed → Confirmed
Changed in launchpad-bazaar:
status: Confirmed → Fix Committed
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.