help-for-command doesn't work in Python 3.x

On Fri, Feb 12, 2010 at 9:12 AM, tbnorth <email address hidden> wrote:

> help-for-command uses sort(cmp), support for comp went away in 3.x,
> because key is better.

Thanks for this report. I'll fix it immediately and add a unit test.

This looks like case that 2to3 missed.

Edward

On Fri, 12 Feb 2010 16:04:18 -0000
"Edward K. Ream" <email address hidden> wrote:

> > help-for-command uses sort(cmp), support for comp went away in 3.x,
> > because key is better.
>
> Thanks for this report. I'll fix it immediately and add a unit test.
>
> This looks like case that 2to3 missed.

I haven't touched help-for-command, but I did just push a cmp free version of leoCommands.py ... sortSiblings to until-4-7-final, FYI. I think the only non-core users of sortSiblings are todo.py and cleo.py, which use it to sort tasks by priority. They're also cmp free in until-4-7-final

Cheers -Terry

On Fri, Feb 12, 2010 at 10:21 AM, tbnorth <email address hidden> wrote:
> On Fri, 12 Feb 2010 16:04:18 -0000
> "Edward K. Ream" <email address hidden> wrote:
>
>> > help-for-command uses sort(cmp), support for comp went away in 3.x,
>> > because key is better.
>>
>> Thanks for this report.  I'll fix it immediately and add a unit test.
>>
>> This looks like case that 2to3 missed.
>
> I haven't touched help-for-command, but I did just push a cmp free
> version of leoCommands.py ... sortSiblings to until-4-7-final, FYI.  I
> think the only non-core users of sortSiblings are todo.py and cleo.py,
> which use it to sort tasks by priority.  They're also cmp free in
> until-4-7-final

In future, please check with me before doing anything to the trunk. I
have fixed 6 methods and added 6 unit tests. Your work is likely to
create conflicts.

Edward

On Fri, Feb 12, 2010 at 12:05 PM, Edward K. Ream <email address hidden> wrote:

> In future, please check with me before doing anything to the trunk.  I
> have fixed 6 methods and added 6 unit tests.  Your work is likely to
> create conflicts.

I seem to be having trouble reading postings. I see you said that you
pushed to the 'until' branch.

I'll merge the revisions soon.

Edward

On Fri, Feb 12, 2010 at 12:09 PM, Edward K. Ream <email address hidden> wrote:

> I'll merge the revisions soon.

Done (by hand) at rev 2963 of the until branch.

All unit tests pass in the merged unitTest.leo, so the two branches
should be back in sync again. That is, I do not expect any conflicts
when doing an official merge later on.

I plan only one more change directly in the trunk: the last remaining
fixes to the goto-global-line command. Maybe today, if things settle
down.

Edward