can't save comment on mp til you click in the text field
Bug #523019 reported by
Martin Pool
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey | ||
Bug Description
To reproduce (in Chromium, and I think in firefox)
Go to a trivially correct mp like https:/
In the review form click "Review: " and choose "Approve"
Try to click "save comment" but you can't, it's greyed out.
Click in the comment field. The "save comment" button is now enabled and can be clicked.
I think it's reasonable to say you can vote without commenting as long as your vote is not "comment only", but the implementation is wrong.
Related branches
lp:~thumper/launchpad/chrome-tab-fix
- Tim Penhey (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedlib/lp/app/javascript/comment.js (+1/-1)
Revision history for this message
| Aaron Bentley (abentley) wrote Re: [Bug 523019] [NEW] can't save comment on mp til you click in the text field | #1 |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: code-review confusing-ui |
| tags: | added: chrome |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| Changed in launchpad: | |
| assignee: | nobody → Tim Penhey (thumper) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> Public bug reported:
>
> To reproduce (in Chromium, and I think in firefox)...
I can reproduce this issue in Chrome 5.0.307.5 dev, but not in Firefox,
which isn't surprising, since I developed it in Firefox.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkt
VZ0An3hxNq5ByFf
=qHpa
-----END PGP SIGNATURE-----