qrevert: Select all checked even if there is some files unchecked

Bug #524483 reported by Alexander Belchenko
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Alexander Belchenko

Bug Description

qrevert has check box "Select / deselect all". This checkbox used to determine whether we should ask user when he want to revert all files but keep panding merge. Ufortunately in this case the question is wrong: even if I have some files unchecked (i.e. not all files reverted) I have this checkbox fully checked. I think it should have 3rd state. See screenshot.

Tags: qrevert

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote :
tags: added: qrevert
Revision history for this message
Alexander Belchenko (bialix) wrote :

to reproduce merge into qbzr trunk revno.1198 qbzr/0.18 branch and then run qrevert.

Changed in qbzr:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Alexander Belchenko (bialix) wrote :

Even simpler to reproduce:

bzr init
bzr mkdir foo
bzr mkdir bar

bzr qrevert

checking at least one item makes select all fully checked.

Changed in qbzr:
importance: Medium → High
Revision history for this message
Alexander Belchenko (bialix) wrote :

in continue of previous comment: in the same situation qci works correctly and shows 3rd state for select all.

Revision history for this message
Alexander Belchenko (bialix) wrote :

The same problem with qadd.

Revision history for this message
Alexander Belchenko (bialix) wrote :

The problem in the overridden function is_item_in_select_all.

Changed in qbzr:
assignee: nobody → Alexander Belchenko (bialix)
milestone: none → 0.18.2
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.