Ubuntu
git-core package

contains a redundant copy of subprocess.py

Bug #53826 reported by Robert Collins
4
Affects Status Importance Assigned to Milestone
git-core (Debian)
Fix Released
Unknown
git-core (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: git-core

git-core ships with subprocess.py rather than using the system one. As python2.4 is our default, and contains this, git-core's copy is unneeded, and (as it is not getting bugfixes from python as regularly as our python does) potentially more buggy.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Thank you for your bug report.
Could you please indicate which version of git-core are you using?

Changed in git-core:
status: Unconfirmed → Needs Info
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Source package: git-core 1:1.4.4.2-1

From package Makefile:
"Define WITH_OWN_SUBPROCESS_PY if you want to use with python 2.3."

From package debian/rules file:
"OPTS =NO_OPENSSL=1 WITH_SEND_EMAIL=1 WITH_OWN_SUBPROCESS_PY=1 prefix=/usr"

Defining WITH_OWN_SUBPROCESS_PY variable forces compiler to use subprocess.py file provided with the source package instead of the one shipped with Ubuntu Python package.

Changed in git-core:
status: Needs Info → Confirmed
Bug Watch Updater (bug-watch-updater)
Changed in git-core:
status: Unknown → Unconfirmed
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 53826] Re: contains a redundant copy of subprocess.py

Ah right. So as python 2.3 is not the default anymore, it should be safe
to change this to remove WITH_OWN_SUBPROCESS_PY=1.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

It should be safe applying this patch.

Bug Watch Updater (bug-watch-updater)
Changed in git-core:
status: Unconfirmed → Fix Committed
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Fixed in Debian with 1:1.5.0~rc3-1 release.

Changed in git-core:
status: Confirmed → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in git-core:
status: Fix Committed → Fix Released
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Version 1:1.5.1.3-1 is now in Gutsy.

Changed in git-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.