File hash is lost if file changed in the middle
Bug #544633 reported by
Facundo Batista
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
High
|
Facundo Batista |
Bug Description
Sync.handle_
If data is ok, it actually processes the event. But if data is not ok, event is lost.
It should somehow trigger a new hashing of the file.
Related branches
lp:~facundo/ubuntuone-client/validate-no-permissions
- Guillermo Gonzalez: Approve
- Tim Cole (community): Approve
-
Diff: 13 lines (+1/-2)1 file modifiedubuntuone/syncdaemon/sync.py (+1/-2)
Changed in ubuntuone-client: | |
status: | Confirmed → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If the file changed it's content, it should not rehash the file, because other FS_FILE_CLOSE_WRITE will be there, and all will be ok.
The problem found is that the permission of the file changed: we should not compare that, as we're not working with that particular metadata.