AssertionError: Don't try to render this page when the user is logged in.

Bug #547054 reported by Gary Poster
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Guilherme Salgado

Bug Description

From Prod yesterday:
  6 AssertionError: Don't try to render this page when the user is logged in.
   Bug: https://launchpad.net/bugs/527985
   GET: 6 Robots: 0 Local: 4
      6 https://launchpad.net/+openid-callback (RootObject:+openid-callback)
       OOPS-1544A1273, OOPS-1544F1247, OOPS-1544H1302, OOPS-1544M1887, OOPS-1544O1495

From Edge yesterday:
  2 AssertionError: Don't try to render this page when the user is logged in.
   Bug: https://launchpad.net/bugs/527985
   GET: 2 Robots: 0 Local: 2
      2 https://edge.launchpad.net/+openid-callback (RootObject:+openid-callback)
       OOPS-1544EB500, OOPS-1544EC464

Another one matsubara highlighted:
https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1541O1653

This is similar to bug 527985, but must have a different cause.

Related branches

Revision history for this message
Guilherme Salgado (salgado) wrote :

To reproduce:

<salgado> 1. log out of LP
<salgado> 2. start logging in in one tab, but stop on login.lp.net/+openid
<salgado> 3. start (and complete) login in another tab
<salgado> 4. go back to first tab and click 'Not now' (or similar)

Revision history for this message
Guilherme Salgado (salgado) wrote :

Another way to reproduce is to do as above but leave the first tab open for 10 minutes or more and then try to complete the authentication there. The authentication will fail because the nonce is expired but the user is already logged in so the login-error page OOPSes.

Revision history for this message
Guilherme Salgado (salgado) wrote :

After discussing this with Gary, when we reach the code path that renders the login-error page and the user is already logged in, we'll just add a notification to the request (stating that the authentication failed but the user is already logged in) and redirect the user to the starting_url included in the OpenID response.

If, for any reason, that's not trivial to do then we'll change the login-error page to display the text that would go in the notification and provide a link to starting_url, when the user is logged in.

Changed in launchpad-foundations:
status: Triaged → In Progress
Ursula Junque (ursinha)
tags: added: oops
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.