Mahara

bad paths to embedded media in html exported views

Bug #548308 reported by Frank Phillips on 2009-11-25

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	Medium	Richard Mansfield	Mahara 1.3.0

Bug Description

Hi,

I am experimenting with Mahara v1.2 and I have found that when I generate a html export of a view that includes embedded media files e.g. mov then the main index.html file appears to unnecessarily append the following "&view=10" to the paths to the media. This appears in line 45 and 57 of the attached file. Consequently when I try to view these artefacts the path is invalid. When I manually delete the characters the view and artefacts behave as expected.

This bug was imported from eduforge.org, see:
https://eduforge.org/tracker/index.php?func=detail&aid=3438&group_id=176&atid=739

See original description

Tags:

Revision history for this message

Frank Phillips (mahara) wrote on 2009-11-25:

main index file of a html export Edit (3.2 KiB, text/html)

Attached index.html.

Revision history for this message

Andrew Nicols (dobedobedoh) wrote on 2009-11-26:

Had a quick look into this bug.

On the face of things, this is caused by a callback to
replace_download_link in export/html/lib.php->filter().

The preg_quote tries to match & but the link actually contains an & and
therefore doesn't match the preg_quote.

So this is arguably a bug with whatever generates the link in the first
place. The regular expression does the right thing if the ampersand is
correctly entity encoded.

The actual download link comes from
artefact/file/blocktype/internalmedia/lib.php->get_download_link();

I've written a patch which changes &view to &view for internalmedia
which fixes the bug (bugfix_3438 on git.luns.net.uk/mahara.git) but this
doesn't seem to correct the actual display of the href for the media in
view.php - something seems to be getting in the way and entity decoding.

Additionally, the various players use the url generated by
get_download_link() without entity decoding the URL for the - I'm not sure
whether the players handle URLs which have been entity encoded.

Hopefully this saves someone else the time of tracking down the bug.

Revision history for this message

Nigel-catalyst (nigel-catalyst) wrote on 2009-11-27:

Assigning to RichardM so it's not forgotten about; I didn't have time to look into this before leaving.

François Marier (fmarier) on 2010-07-13

Changed in mahara:
milestone:	none → 1.3.0
assignee:	Richard Mansfield (richard-mansfield) → nobody

Richard Mansfield (richard-mansfield) on 2010-07-18

Changed in mahara:
assignee:	nobody → Richard Mansfield (richard-mansfield)

Revision history for this message

Richard Mansfield (richard-mansfield) wrote on 2010-07-19:

Andrew,

Applying your patch for this doesn't seem to cause any trouble for me, so I've pushed it. But your comment above implies there might be some other page that gets broken. Do you remember what that was about, or do you think it's okay to just apply it?

Changed in mahara:
status:	Confirmed → Fix Committed

Richard Mansfield (richard-mansfield) on 2010-09-10

Changed in mahara:
status:	Fix Committed → Fix Released

Revision history for this message

Richard Mansfield (richard-mansfield) wrote on 2010-10-08:

The fix for this was apparently causing breakage in media players on some OSes (see https://bugs.launchpad.net/mahara/+bug/638751). So I reverted this fix (now outputs & rather than & again) and changed replace_download_link in export/html/lib.php->filter() to search for &amp, &, or %26 in the download.php links.

Revision history for this message

Ulises Martínez Miralles (ulmarmir) wrote on 2018-03-15:

I'm using Mahara 17.04.3.
If we embed Youtube videos with 'https://' it is exported and shows correctly.
If we embed them with 'http://' the URLs are changed to start with '//'.
So if we embed the 'https://www.youtube.com/embed/<id>' it is shown correctly.
If we embed the 'http://www.youtube.com/embed/<id>' it is replaced with the '//www.youtube.com/embed/<id>'.