Launchpad itself

+filebug page really should have tabindex for "Submit Bug Report" Button

Bug #558419 reported by Dustin Kirkland 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Won't Fix
High
Graham Binns

Bug Description

Okay, this has driven me bonkers for the last time ...

I spend a long time writing a really quality bug report, verbosely filling out the "Further information" section.

I'm ready to submit, so I <tab> out of the "Futher Information" textarea and hit enter, expecting that to submit my bug report.

But low and behold, the tab index following the input field is not the submit button. Oh no, it's a hyperlink to a wiki page on how to file a bug or some such. And that page doesn't open in a new tab. No. It takes over the current tab. And when I try to go back in the browser, I end up 2 pages back, and all of my glorious detail is lost in the ether. I lose.

This is simple to fix with a tabindex value in each of the form elements.

Deryck Hodge (deryck)
affects: launchpad → malone
Revision history for this message
Deryck Hodge (deryck) wrote :

tabindex will help this specific case, definitely. But there is also bug 553946. We should preserve what has been input despite the AJAXification of this page.

Changed in malone:
status: New → Triaged
importance: Undecided → High
tags: added: story-ajaxify-dupe-finder
Revision history for this message
Dustin Kirkland  (kirkland) wrote : Re: [Bug 558419] Re: +filebug page really should have tabindex for "Submit Bug Report" Button

Agreed, a "save draft" type thing like Gmail does would be really nice.

I'm assuming that far harder to do than just fixing the tab index.

At this point, I'm done composing bug reports in the LP web interface,
and instead doing it in a buffer in vim, and then copy and pasting it
over.

Deryck Hodge (deryck)
tags: added: dhrb
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

I HATE THIS F*CKING BUG

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Just bit me again... I swear, I loose a little bit of sanity every time it happens.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Another idea...

LP could have those links to the wiki, etc, open in a new tab/window. This would make a lot of sense, actually. Add target="_new" in the <a>.

Francis J. Lacoste (flacoste)
tags: added: escalated
Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 558419] [NEW] +filebug page really should have tabindex for "Submit Bug Report" Button

On Wednesday, 15 December 2010, Francis J. Lacoste
<email address hidden> wrote:
> ** Tags added: escalated
>

This should be an easy fix. I can take care of it as part of the bug
jam tomorrow.

--
Graham Binns
http://grahambinns.com

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks so much, Graham.

Graham Binns (gmb)
Changed in malone:
status: Triaged → In Progress
assignee: nobody → Graham Binns (gmb)
tags: added: bugjam2010
Revision history for this message
Graham Binns (gmb) wrote :

> LP could have those links to the wiki, etc, open in a new tab/window. This would make a lot of sense, actually.
> Add target="_new" in the <a>.

To fix that in the short term someone from the Ubuntu Bugs team could update the bug filing guidelines for Ubuntu so that all the links have that attribute.

Revision history for this message
Dustin Kirkland  (kirkland) wrote : Re: [Bug 558419] Re: +filebug page really should have tabindex for "Submit Bug Report" Button

Thanks, I'll talk to them about that.

Revision history for this message
Graham Binns (gmb) wrote :

Adding tabindices to the elements in the form is proving prohibitively difficult due to the way that Zope handles widgets and actions, so I'm going to go with Dustin's other suggestion and add a new formatter which will make the links open in a new page.

Incidentally, it turns out that I was wrong about updating the bug reporting guidelines themselves; those links are created by Launchpad (hence the new formatter).

Revision history for this message
Graham Binns (gmb) wrote :

I'm tracking the target="_new" stuff in bug 691076, just in case there's more work that we can do here.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks, Graham.

I, too, had looked at the LP code around this, and found that the form
elements were spread across more than one file, which made
incrementing the tabindex pretty hard. Too hard, at least, for me, as
an inexperienced Launchpad dev.

In any case, the target=_new fix will keep me from losing data, which
is the primary goal. Thanks!

Revision history for this message
Graham Binns (gmb) wrote :

As I said above, whilst it's possible to add tabindices to buttons and widgets in Zope, it's pretty horrible to have to do. I'm going to close this bug as Won't Fix and open a new one specifically about making that easier and / or automatic.

A fix for bug 691076 (_new target for links in bug reporting guidelines) is now in review.

Changed in launchpad:
status: In Progress → Won't Fix
Revision history for this message
Graham Binns (gmb) wrote :

For reference, the new bug is bug 691560.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12144 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12144>.

tags: added: qa-needstesting
Changed in launchpad:
status: Won't Fix → Fix Committed
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Reverted the qa-tagger mistakes.

Changed in launchpad:
status: Fix Committed → Won't Fix
tags: removed: qa-needstesting
Francis J. Lacoste (flacoste)
tags: added: qa-untestable
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.