[disks-admin] dapper disks-admin crashes on rpc_pipefs

Bug #56560 reported by Gerhard Schneider
4
Affects Status Importance Assigned to Milestone
gnome-system-tools (Ubuntu)
Invalid
Medium
Ubuntu Desktop Bugs

Bug Description

Binary package hint: gnome-system-tools

gnome-system-tools 2.14.0-0ubuntu11

disks-admin crashes on that /etc/fstab entry

rpc_pipefs /var/lib/nfs/rpc_pipefs rpc_pipefs defaults 0 0

the other possibility

sunrpc /var/lib/nfs/rpc_pipefs rpc_pipefs defaults 0 0

is working.

If the old rpc_pipefs entry (still supported by kernel and user level tools)
is not supported anymore there should be an error message but no crash.

                                                        GS

Tags: disks-admin
Revision history for this message
Vassilis Pandis (pandisv) wrote :

Thanks for reporting this. Can you please get a backtrace of gnome-system-tools by following the procedures described at http://wiki.ubuntu.com/DebuggingProgramCrash? Thanks...

Changed in gnome-system-tools:
status: Unconfirmed → Needs Info
Revision history for this message
Gerhard Schneider (gs-ilsb) wrote : Re: [Bug 56560] Re: dapper disks-admin crashes on rpc_pipefs

Vassilis Pandis wrote:
> Thanks for reporting this. Can you please get a backtrace of gnome-
> system-tools by following the procedures described at
> http://wiki.ubuntu.com/DebuggingProgramCrash? Thanks...
>
> ** Changed in: gnome-system-tools (Ubuntu)
> Status: Unconfirmed => Needs Info
>
here it goes..

                                          GS

--
Gerhard Schneider
Institute of Lightweight Design and e-Mail:<email address hidden>
Structural Biomechanics (E317) Tel.: +43 1 58801 31716
Vienna University of Technology / Austria Fax: +43 1 58801 31799
A-1040 Wien, Gusshausstrasse 27-29 http://www.ilsb.tuwien.ac.at/~gs/

Revision history for this message
Gerhard Schneider (gs-ilsb) wrote : Re: dapper disks-admin crashes on rpc_pipefs

launchpad ate the attachment..

Revision history for this message
Vassilis Pandis (pandisv) wrote :

True - AFAIK you can't use the e-mail interface to add attachments, yet.

Changed in gnome-system-tools:
status: Needs Info → Confirmed
Revision history for this message
Vassilis Pandis (pandisv) wrote :

This patch fixes it for me. It will also fix the case of a malformed "device" (which I think is when you specify something like /dev/aa0 in fstab, i.e. not without four chars after the last '/').

Changed in gnome-system-tools:
importance: Untriaged → Medium
Revision history for this message
Gerhard Schneider (gs-ilsb) wrote :

Sorry, not compiling.

What is g_strlen (and where is it)?

One bracket is missing, too..

                                              GS

Revision history for this message
Vassilis Pandis (pandisv) wrote :

Ooops, sorry yes. I added that g_strlen() call manually afterwards (I was pretty sure glib would have such a function for consistency :-) when I noticed that there may be a possibility of a buffer overrun (to fix the crash, only changing the position of the +4 was neccessary). I'll provide a corrected patch in a few hours.

Revision history for this message
Vassilis Pandis (pandisv) wrote :

Here's a patch that is hopefully OK. I'm not sure if I took the debian patches under consideration correctly, but to apply:

apt-get source gnome-system-tools
cd gnome-system-tools-2.14.0/
dpkg-buildpackage -rfakeroot
cat ~/gst.patch | patch -p0
make

in src/disks/ resides your binary. I'm not very good at packaging so I don't know if I did create the patch correctly. At any rate the changes to the code are minor and Sebastien can easily fix it himself :-)

Revision history for this message
Gerhard Schneider (gs-ilsb) wrote :

compiling and solving the rpc_pipefs problem.

Thank you!
                                       GS

Revision history for this message
Sebastien Bacher (seb128) wrote :

Marking the bug Rejected, the tools has been deprecated since. We might backport the patch on dapper later though it's not likely since that issue has not been reported by a lot of people

Changed in gnome-system-tools:
assignee: nobody → desktop-bugs
status: Confirmed → Rejected
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.